Module: kamailio Branch: master Commit: 0a11489d4b699a62596b2c4626171e8d92e966fd URL: https://github.com/kamailio/kamailio/commit/0a11489d4b699a62596b2c4626171e8d...
Author: Daniel-Constantin Mierla miconda@gmail.com Committer: Daniel-Constantin Mierla miconda@gmail.com Date: 2024-01-21T10:20:39+01:00
lib/srdb2: review and adapt old comments
---
Modified: src/lib/srdb2/db_cmd.c Modified: src/lib/srdb2/db_gen.h
---
Diff: https://github.com/kamailio/kamailio/commit/0a11489d4b699a62596b2c4626171e8d... Patch: https://github.com/kamailio/kamailio/commit/0a11489d4b699a62596b2c4626171e8d...
---
diff --git a/src/lib/srdb2/db_cmd.c b/src/lib/srdb2/db_cmd.c index 2782f4dc7c5..9ba1d22ee66 100644 --- a/src/lib/srdb2/db_cmd.c +++ b/src/lib/srdb2/db_cmd.c @@ -58,7 +58,7 @@ db_cmd_t *db_cmd(enum db_cmd_type type, db_ctx_t *ctx, char *table,
newp->type = type;
- /** FIXME: it is not clear now that this is necessary + /** NOTE: it is not clear now that this is necessary * when we have match and value separate arrays */ if(result) { newp->result = db_fld_copy(result); @@ -78,7 +78,7 @@ db_cmd_t *db_cmd(enum db_cmd_type type, db_ctx_t *ctx, char *table, goto err; }
- /* FIXME: This should be redesigned so that we do not need to connect + /* NOTE: This should be redesigned so that we do not need to connect * connections in context before commands are created, this takes splitting * the command initialization sequence in two steps, one would be creating * all the data structures and the second would be checking corresponding @@ -242,7 +242,6 @@ int db_exec(db_res_t **res, db_cmd_t *cmd) return -1; }
- /* FIXME */ db_payload_idx = 0; ret = cmd->exec[0](r, cmd); if(ret < 0) { diff --git a/src/lib/srdb2/db_gen.h b/src/lib/srdb2/db_gen.h index eca24c76046..f8dd483b87a 100644 --- a/src/lib/srdb2/db_gen.h +++ b/src/lib/srdb2/db_gen.h @@ -95,7 +95,7 @@ extern "C" */
/* - * FIXME: We should find some other way of doing this than just copying + * NOTE: We should find some other way of doing this than just copying * and pasting the code from STAILQ_FOREACH */ #define DBLIST_FOREACH(var, head) \ @@ -111,7 +111,7 @@ extern "C" */
/* - * FIXME: We should find some other way of doing this than just copying + * NOTE: We should find some other way of doing this than just copying * and pasting the code from STAILQ_FOREACH_SAFE */ #define DBLIST_FOREACH_SAFE(var, head, tvar) \
-
Daniel-Constantin Mierla