- adds header parser to fill headers in msg structure. msg gets copied but many of the headers don't when msg_apply_changes is called. - reported in #2803
<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #2803
#### Description
adds header parser to fill headers in msg structure. msg gets copied but many of the headers don't get filled when msg_apply_changes is called. This can cause segmentation fault by calling null pointers. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2877
-- Commit Summary --
* <a href="https://github.com/kamailio/kamailio/pull/2877/commits/a3a351c8b76abdd3da73b619456dc2e61c3778c1">core: fixup sip_msg_apply_changes</a>
-- File Changes --
M src/core/msg_translator.c (8)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2877.patch https://github.com/kamailio/kamailio/pull/2877.diff
Thanks for the PR!
However I pushed a different commit (d5c1b46) to have the same behaviours as when the sip message is received. Kamailio does not parse all the headers before config is executed due to internal designed, so modules have to check if needed headers are parsed, but Call-Id is indeed parsed before config execution.
If there is still an issue after with commit d5c1b46, then open an issue. If works, then I will backport.
Closed #2877.