#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
We have locally needed to update the `from_tag` and `to_tag` columns in `acc`, `dialog` and `siptrace` as we get requests which are larger than the defaults can handle.
While bumping the limit, I added two entities to `entities.xml` to get consistent sizes for `from_tag` and `to_tag` in the tables. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1921
-- Commit Summary --
* lib/srdb1: schema - add definitions for from_tag and to_tag * lib/srdb1: schema - use defined entities for from_tag and to_tag. * kamctl: regenerated db schema files for from_tag and to_tag changes.
-- File Changes --
M src/lib/srdb1/schema/acc.xml (4) M src/lib/srdb1/schema/dialog.xml (4) M src/lib/srdb1/schema/entities.xml (2) M src/lib/srdb1/schema/missed_calls.xml (4) M src/lib/srdb1/schema/pr_active_watchers.xml (4) M src/lib/srdb1/schema/pr_pua.xml (4) M src/lib/srdb1/schema/rls_watchers.xml (4) M src/lib/srdb1/schema/sca.xml (4) M src/lib/srdb1/schema/sip_trace.xml (4) M utils/kamctl/db_sqlite/acc-create.sql (8) M utils/kamctl/db_sqlite/dialog-create.sql (4) M utils/kamctl/db_sqlite/presence-create.sql (8) M utils/kamctl/db_sqlite/rls-create.sql (4) M utils/kamctl/db_sqlite/sca-create.sql (4) M utils/kamctl/db_sqlite/siptrace-create.sql (4) M utils/kamctl/mysql/acc-create.sql (8) M utils/kamctl/mysql/dialog-create.sql (4) M utils/kamctl/mysql/presence-create.sql (8) M utils/kamctl/mysql/rls-create.sql (4) M utils/kamctl/mysql/sca-create.sql (4) M utils/kamctl/mysql/siptrace-create.sql (4) M utils/kamctl/oracle/acc-create.sql (8) M utils/kamctl/oracle/dialog-create.sql (4) M utils/kamctl/oracle/presence-create.sql (8) M utils/kamctl/oracle/rls-create.sql (4) M utils/kamctl/oracle/sca-create.sql (4) M utils/kamctl/oracle/siptrace-create.sql (4) M utils/kamctl/postgres/acc-create.sql (8) M utils/kamctl/postgres/dialog-create.sql (4) M utils/kamctl/postgres/presence-create.sql (8) M utils/kamctl/postgres/rls-create.sql (4) M utils/kamctl/postgres/sca-create.sql (4) M utils/kamctl/postgres/siptrace-create.sql (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1921.patch https://github.com/kamailio/kamailio/pull/1921.diff
Looks good to me. There is no maximum to/from tag length defined in RFC 3261, so longer tags can certainly happens.
This is change that affects several modules. But It should have no database size implications as MySQL only stores in a VARCHAR the actual used characters (plus lengths) [link](https://dev.mysql.com/doc/refman/8.0/en/storage-requirements.html#data-types...). It also should not affect backward compatibility, Kamailio 5.1.x/5.2.x should run just fine with the new table structure and vice-versa.
Merged #1921 into master.
Thank you, merged