[kamailio/kamailio] radius : Fixes use of freeradiusclient library (#1170)

List overview All Threads
Download

newer

older

git:master:64c529d1: permissions:...

[kamailio/kamailio] jansson: can't...

Yasin CANER

28 Jun 2017 28 Jun '17

12:10 p.m.

Fixes use of freeradiusclient library for radius modules. Setting right path. You can view, comment on, or merge this pull request online at:

https://github.com/kamailio/kamailio/pull/1170

-- Commit Summary --

* radius : Fixes freeradiusclient library

-- File Changes --

M src/modules/misc_radius/radius.h (11)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/1170.patch https://github.com/kamailio/kamailio/pull/1170.diff

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1170

Attachments:

attachment.html (text/html — 2.5 KB)

Show replies by date

Yasin CANER

28 Jun 28 Jun

12:11 p.m.

i hope my commit message is enough for explanation

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1170#issuecomment-311641408

Olle E. Johansson

12:27 p.m.

You are dropping backwards portability. Any particular reason for that?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1170#issuecomment-311644670

Yasin CANER

12:38 p.m.

Hello, Because there is confict between Makefile.radius . Makefile.radius need to setting freeradius value to use.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1170#issuecomment-311647153

Daniel-Constantin Mierla

4:18 p.m.

If I got it right, you interchanged the freeradius client with radiusclient-ng, but the condition at the top is negated, respectively `#ifndef USE_FREERADIUS`. With the patch it seems that when USE_FREERADIUS is defined, the radiusclient-ng is going to be used -- that's not right.

Have you encountered any issue and this patch is fixing it?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1170#issuecomment-311711541

Yasin CANER

29 Jun 29 Jun

6:03 a.m.

Hello @miconda , there is conflict with Makefile.radius . this file selects freeradiusclient without settting freeradius, but makefile.radius needs to FREERADIUS for using freeradiusclient.h . so compiling couldnt find .h file, gives error. Could you check it again , please.

ERROR : `In file included from acc_radius_mod.c:44: ../misc_radius/radius.h:38:31: warning: radiusclient-ng.h: No such file or directory `

Thanks.

` INCLUDES+=-I$(LOCALBASE)/include

ifeq ($(FREERADIUS),1)

# - freeradius-client library DEFS+= -DUSE_FREERADIUS RADIUSCLIENT_LIB=freeradius-client

else ifeq ($(RADCLI),1)

# - radcli library DEFS+= -DUSE_RADCLI RADIUSCLIENT_LIB=radcli

else # - radiusclient-ng v5 or v4 library ifneq ($(radiusclient_ng), 4)

# radiusclient-ng 5+ # DEFS+=-DRADIUSCLIENT_NG_5P RADIUSCLIENT_LIB=radiusclient-ng

else

DEFS+=-DRADIUSCLIENT_NG_4 RADIUSCLIENT_LIB=radiusclient

endif endif

endif

LIBS=-L$(LOCALBASE)/lib -l$(RADIUSCLIENT_LIB) `

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1170#issuecomment-311870676

Daniel-Constantin Mierla

6:08 a.m.

The default is to use radiusclient-ng library. To use freeradius-client, then you have to set FREERADIUS=1 in the make command. Am I missing something? Have you set FREERADIUS=1 and doesn't work?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1170#issuecomment-311871434

Yasin CANER

6:21 a.m.

Hello @miconda , I am sorry for my english isnt enough for explain it. if i set "export FREERADIUS=1" Makefile.radius selecting "freeradius-client.h" but radius.h selects radiusclient-ng.h . if i dont set FREERADIUS Makefile.radius selects "radiusclient-ng.h" but radius.h selects ""freeradius-client.h" Here is results,

` export FREERADIUS=1 make all make -C src/ all make[1]: Entering directory `/usr/src/kamailio-5.0.2/src' make[3]: `libsrdb2.so.1.0' is up to date. make[3]: `libsrdb1.so.1.0' is up to date. CC (gcc) [M acc_radius.so] acc_radius_mod.o In file included from acc_radius_mod.c:44: ../misc_radius/radius.h:43:30: warning: radiusclient-ng.h: No such file or directory acc_radius_mod.c: In function ‘init_acc_rad’:

` ` make clean make -C src/ clean make[1]: Entering directory `/usr/src/kamailio-5.0.2/src' make[2]: *** No rule to make target `clean'. Stop. make --no-print-directory -C lib clean Making clean in binrpc Making clean in cds Making clean in ims Making clean in presence Making clean in print Making clean in shm_regex Making clean in srdb1 Making clean in srdb2 Making clean in srutils Making clean in trie Making clean in xcap make[1]: Leaving directory `/usr/src/kamailio-5.0.2/src' make include_modules="db_mysql acc_radius auth_radius misc_radius carrierroute utils " cfg make -C src/ cfg target architecture <x86_64>, host architecture <x86_64> make[1]: Entering directory `/usr/src/kamailio-5.0.2/src' making config... rm -f modules.lst make --no-print-directory modules.lst saving modules list... make[1]: Leaving directory `/usr/src/kamailio-5.0.2/src' make all make -C src/ all make[1]: Entering directory `/usr/src/kamailio-5.0.2/src' CC (gcc) [kamailio] main.o .... LD (gcc) [M db_mysql.so] db_mysql.so CC (gcc) [M acc_radius.so] acc_radius_mod.o In file included from acc_radius_mod.c:44: ../misc_radius/radius.h:43:30: warning: radiusclient-ng.h: No such file or directory acc_radius_mod.c: In function ‘init_acc_rad’:

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1170#issuecomment-311873404

Daniel-Constantin Mierla

6:39 a.m.

Something has to been done wrong in your system. I tried and works as expected here. Also debian and rpm packaging are using same mechanism and the packages build fine.

Are you sure you don't have other changes done there or something else setting FREERADIUS to 0?

Try to add FREERADIUS=1 to src/Makefile.radius and see if goes ok.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1170#issuecomment-311876298

Yasin CANER

7:18 a.m.

Hello, after cloning from git , i didnt get any error. i will test again with version 5. thanks for support.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1170#issuecomment-311883384

Yasin CANER

7:18 a.m.

Closed #1170.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1170#event-1143668552

2853

Age (days ago)

2854

Last active (days ago)

sr-dev@lists.kamailio.org

10 comments

3 participants

tags (0)

participants (3)

Daniel-Constantin Mierla
Olle E. Johansson
Yasin CANER