In order to be able to generate reproducible builds we should not include an auto-generated cert in the default install-cfg rule at tls You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/282
-- Commit Summary --
* tls: install-cfg: do not generate tls-cert by default
-- File Changes --
M modules/tls/Makefile (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/282.patch https://github.com/kamailio/kamailio/pull/282.diff
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/282
FTR: https://reproducible.debian.net/rb-pkg/unstable/amd64/kamailio.html
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/282#issuecomment-129745755
Thanks! I think the docs of tls module needs a note about what to do now for generating/installing the certificates:
``` make install-tls-cert ```
Then, this can be merged.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/282#issuecomment-129777328
still WIP, I will add the note here too
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/282#issuecomment-129812787
uhm, there is plenty of info at tls/doc/certs_howto.xml already
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/282#issuecomment-129858858
But is it about the fact that they are not generated anymore automatically at install. That's the note I would like to have, to reflect the change you do with the patch, so one has to execute manually the command for generating the certs.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/282#issuecomment-130182553
Something like that is enough?
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/282#issuecomment-130186901
Should be ok for the moment.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/282#issuecomment-130225079
Merged #282.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/282#event-380088578
-
Daniel-Constantin Mierla -
Victor Seva