I run Kamailio with ``` log_stderror=yes /* LOG Levels: 3=DBG, 2=INFO, 1=NOTICE, 0=WARN, -1=ERR, ... */ debug=-1 ``` and inspect the output. Some messages from the websocket module are logged repeatedly at ERROR-level, but they are in no way errors. This changes moves such periodially logged no-error messages to debug-level INFO. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3349
-- Commit Summary --
* websocket: move some logging from ERROR to INFO
-- File Changes --
M src/modules/websocket/doc/websocket_admin.xml (2) M src/modules/websocket/utf8_decode.h (2) M src/modules/websocket/ws_frame.c (6)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3349.patch https://github.com/kamailio/kamailio/pull/3349.diff
if you're changing this maybe set to `L_DEBUG` instead ? or add a mod param for this ?
@dilyanpalauzov pushed 1 commit.
8fba637cbcd583a3d9f5dd0e1aa02cfa7db43814 websocket: move some logging from ERROR to INFO
I have changed the logging level to DEBUG (`LM_DBG()`).
Thanks for the PR. It probably needs to be applied manually, as it also contains some (unrelated) documentation changes.
This falls again in the debate of how far we go changing levels for log messages, because the importance of them is relative from person to person.
The designed way was that if someone considers the logging too excesive for a particular deployment, then the `debug` core parameter has to be decreased.
Similar to #3296.
On the changes themselves, the messages were about errors for sending messages or keepalives, not when sending was successful, they should not be periodical logs if the connections are ok.
I also see an INFO changed to DEBUG when the connection was unexpectedly lost.
@dilyanpalauzov pushed 1 commit.
e250e9264a17bb1ee028ec0d3b9ffb864aef5325 websocket: move some logging from ERROR to INFO
@dilyanpalauzov pushed 1 commit.
cbd06b1c67fa9dc9988496f1d540581a41d5e583 websocket: typos
I also see an INFO changed to DEBUG when the connection was unexpectedly lost.
This change was not intended, I have reverted it.
I agree the remaining changes are related to error conditions, not just to basic logging. I have removed them, leaving in the changeset only typos.
Merged #3349 into master.
-
Daniel-Constantin Mierla -
Henning Westerholt
-
lazedo
-
Дилян Палаузов