Module: sip-router Branch: kamailio_3.0 Commit: 96d8f8335587d35b6a2b887f597fdc68de799875 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=96d8f833...
Author: Henning Westerholt henning.westerholt@1und1.de Committer: Marius Zbihlei marius.zbihlei@1and1.ro Date: Tue Jun 29 12:26:30 2010 +0200
auc(k): fix error in authentification: Digest should be compared case insensitive (cherry picked from commit 3f5909fd3ca55aa43148d81a8874eaeaeaf91968)
---
modules_k/uac/auth_hdr.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/modules_k/uac/auth_hdr.c b/modules_k/uac/auth_hdr.c index 269f0bb..c8fd359 100644 --- a/modules_k/uac/auth_hdr.c +++ b/modules_k/uac/auth_hdr.c @@ -112,7 +112,7 @@ int parse_authenticate_body( str *body, struct authenticate_body *auth) while (p<end && isspace((int)*p)) p++; if (p+AUTHENTICATE_DIGEST_LEN>=end ) goto parse_error; - if (strncmp(p,AUTHENTICATE_DIGEST_S,AUTHENTICATE_DIGEST_LEN)!=0) + if (strncasecmp(p,AUTHENTICATE_DIGEST_S,AUTHENTICATE_DIGEST_LEN)!=0) goto parse_error; p += AUTHENTICATE_DIGEST_LEN; if (!isspace((int)*p))
2010/6/29 Marius Zbihlei marius.zbihlei@1and1.ro:
auc(k): fix error in authentification: Digest should be compared case insensitive
Hi, does it refer to the hexadecimal encoded Digest response?
On Tuesday 29 June 2010, Iñaki Baz Castillo wrote:
2010/6/29 Marius Zbihlei marius.zbihlei@1and1.ro:
auc(k): fix error in authentification: Digest should be compared case insensitive
Hi, does it refer to the hexadecimal encoded Digest response?
Hi Iñaki,
no, it refers to the spelling of 'Digest'. This was checked case sensitive, and you pointed out in some (a bit older) thread that this is wrong according to 3261.
Cheers,
Henning
2010/6/29 Henning Westerholt henning.westerholt@1und1.de:
On Tuesday 29 June 2010, Iñaki Baz Castillo wrote:
2010/6/29 Marius Zbihlei marius.zbihlei@1and1.ro:
auc(k): fix error in authentification: Digest should be compared case insensitive
Hi, does it refer to the hexadecimal encoded Digest response?
Hi Iñaki,
no, it refers to the spelling of 'Digest'. This was checked case sensitive, and you pointed out in some (a bit older) thread that this is wrong according to 3261.
Ah ok. I was realizing of it right now when inspecting the value of AUTHENTICATE_DIGEST_S :)
Thanks.