<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail --> Primary goal is to update doc, for Rx_AAR() function, to mention is used only for replies.
I've also changed some LM_DBG to LM_WARN but I can revert that on request (don't want to overflow noone with warnings) You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3521
-- Commit Summary --
* ims_qos: doc update and warn logs
-- File Changes --
M src/modules/ims_qos/doc/ims_qos_admin.xml (6) M src/modules/ims_qos/ims_qos_mod.c (16)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3521.patch https://github.com/kamailio/kamailio/pull/3521.diff
@smititelu pushed 1 commit.
78a675adbeed0f443f0b521dab0608ef59dbbbeb ims_qos: doc update and warn logs
@carstenbock what do you think of this?
@miconda commented on this pull request.
Removing the condition `if(msg->first_line.type != SIP_REPLY) {` seems legit from native kamailio.cfg scripting language as the exports limits to ONREPLY_ROUTE and the internal interpreter can detect it, but for KEMI (which might not be the case here, however, making it as a general comment), it is not possible to detect at startup where a function is going to used. Therefore, thinking of thee future, it is probably better to have runtime checks about the type of message or route block. Even for the native scripting language, there are workarounds in some cases to execute a function in another route block (e.g., execute request-specific exported functions inside a `route[x]` block that is called from on/reply route block.
From that perspective, I would not remove this check. Over all, I am fine to merge it with this change as well. Nowadays the config writer should be more careful anyhow, especially if using KEMI, to be sure functions are not used in a wrong place.
Thanks for the feedback! Will update PR soon. Did not know about the ```route[x]``` stuff.
@smititelu pushed 1 commit.
740fd78205ded225e8964f29e3f702798722da22 ims_qos: doc and logs update
The requested change have been done (related to the first_line check), so merging it. Thank you.
Merged #3521 into master.
@smititelu : Looks good to me, sorry was on holiday in the last two weeks.... :-)
-
carstenbock -
Daniel-Constantin Mierla
-
Henning Westerholt
-
Stefan Mititelu