<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail --> http_async_client module needs to parse http replies. Currently HTTP/2 is not supported by the core parser. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2132
-- Commit Summary --
* core: add support for parsing http/2 replies parsing
-- File Changes --
M src/core/parser/msg_parser.h (7) M src/core/parser/parse_fline.c (34) M src/core/parser/parse_fline.h (5)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2132.patch https://github.com/kamailio/kamailio/pull/2132.diff
miconda commented on this pull request.
@@ -47,7 +47,10 @@
#define SIP_VERSION_LEN 7
#define HTTP_VERSION "HTTP/1." -#define HTTP_VERSION_LEN (sizeof(HTTP_VERSION)-1) +#define HTTP_VERSION_LEN (sizeof(HTTP2_VERSION)-1)
Was the above change somehow done unintentionally? Because I see no reason to have `HTTP_VERSION_LEN` be based on size of `HTTP*2*_VERSION` value.
grumvalski commented on this pull request.
@@ -47,7 +47,10 @@
#define SIP_VERSION_LEN 7
#define HTTP_VERSION "HTTP/1." -#define HTTP_VERSION_LEN (sizeof(HTTP_VERSION)-1) +#define HTTP_VERSION_LEN (sizeof(HTTP2_VERSION)-1)
Yes, it was not done intentionally. I'll fix and force push if you agree.
@grumvalski pushed 1 commit.
17be36102e3a1c286c69a5da193dd8405000ab62 core: add support for parsing http/2 replies parsing
It can be merged. Probably can be considered for backporting at least for 5.3.x, otherwise over the time I expect won't work to do http queries in more and more many cases.
I agree that the usage of http/2 will become more and more common. If you agree, I'll also backport it to 5.2.x since this is still a supported version.
Merged #2132 into master.
If the patch applies cleanly to 5.2 branch, a backport should be ok there as well. If there are other (functional) changes necessary before it could be applied, then it would be better to ask people to upgrade in this case to 5.3.x
The patches applied cleanly on both branches, I needed a couple of days to test. I've cherry-picked the commit.