<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [X] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description Currently re-registration is not happening in half of expire time. sometime its reaching near to expire time then sending re-registration. usually sip servers expect re-registration to happen in half of expire time. <!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2765
-- Commit Summary --
* uac: registration refresh should in half time of expire
-- File Changes --
M src/modules/uac/uac_reg.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2765.patch https://github.com/kamailio/kamailio/pull/2765.diff
Hello, thanks for the pull request. If I do not misread the standard ([link](https://datatracker.ietf.org/doc/html/rfc3261#section-10.2.4)), there is no particular requirement for your change. Have you tried to just set a lower reg_retry_interval? E.g.: - reg_retry_interval: 180 - expires: 360
@henningw reg_retry_interval is used for failed registration retry. i am looking for refreshing registration. Also just think about having multiple pbx that expect different expire then reg_timer_interval will not work. Also what changes i made that's apply to every where.
I quoted the wrong parameter, i meant the reg_timer_interval: https://kamailio.org/docs/modules/devel/modules/uac.html#uac.p.reg_timer_int...
The refresh threshold could be of course configured with a module parameter, keeping the current behavior as default.
yeah i checked this too reg_timer_interval but this is not getting apply if kamailio is sending register to different pbx that are expecting different expire time.
Doing registration refresh at the half of the expires interval is not a common practice, nor a requirement from SIP RFC, like @henningw pointed out. I haven't noticed such behaviour by sip phones, either. I second that such behaviour needs a module parameter to control it, default behaviour should stay like it is now.
@henningw @miconda agreed its not hard core requirement from sip rfc , i will setup an module parameter for the same and will keep default behaviour as it is. :-)
@surendratiwari3 - do you still plan to use this PR or will you open a new one once you get the time to work further on it?
Long time no activity. Make a new pull request with a modparam, should this feature still be wanted.
Closed #2765.
-
Daniel-Constantin Mierla -
Henning Westerholt
-
Surendra Tiwari