Implementation of geoip2 module based on the new Maxmind geoip2 database format. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/52
-- Commit Summary --
* Geoip2 module
-- File Changes --
A modules/geoip2/Makefile (15) A modules/geoip2/README (146) A modules/geoip2/doc/Makefile (4) A modules/geoip2/doc/geoip2.xml (36) A modules/geoip2/doc/geoip2_admin.xml (175) A modules/geoip2/geoip2_mod.c (139) A modules/geoip2/geoip2_pv.c (476) A modules/geoip2/geoip2_pv.h (40)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/52.patch https://github.com/kamailio/kamailio/pull/52.diff
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/52
Couple of clarifications to be made, if you are aware of the answers:
* does the new geoip database/api work with both IPv4 and IPv6? * would be there cases to use old geoip module and the new one? I see they depend on different libraries, I assume the new one is not available in old distros, but then, can be there situations when both libraries are available?
Right now, the new module exports same functions and variables as old geoip module. In the case both can be used, then the functions/vars should be renamed to reflect the new module name. The config needs to be changed anyhow to load the new module.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/52#issuecomment-71910666
Geoip2 databases provide both v4 and v6 addresses lookup. I see no use cases when both modules might be used, that's why I use the same exported function name to minimize changes in kamailio cfg script. The only change required is to load/set parameter of another module.
Maxmind pushes new developments to use geoip2 databases and API, the old API is still supported by maxmind but is obsoleted.
On Wednesday 28 January 2015 12:35:17 Daniel-Constantin Mierla wrote:
Couple of clarifications to be made, if you are aware of the answers:
- does the new geoip database/api work with both IPv4 and IPv6?
- would be there cases to use old geoip module and the new one? I see they
depend on different libraries, I assume the new one is not available in old distros, but then, can be there situations when both libraries are available?
Right now, the new module exports same functions and variables as old geoip module. In the case both can be used, then the functions/vars should be renamed to reflect the new module name. The config needs to be changed anyhow to load the new module.
Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/52#issuecomment-71910666
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/52#issuecomment-71918241
It appears that some older versions (but still in use), have the old libs, so I think this new module should come have the variables and name of the functions changed, because the module name is also different, therefore the configuration file must be edited anyhow.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/52#issuecomment-72434454
I renamed exported fumction to geoip2_match()
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/52#issuecomment-72474052
Rename also the variable exported as well as the C functions and variables that are not static, otherwise it can result in conflicts if both geoip modules are used. Moreover, makes development harder because searching for a function/symbol (and related things such as auto completion, tags jumping) gives more results.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/52#issuecomment-72475613
I made global geoip->geoip2 names change.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/52#issuecomment-72480798
I will commit your patches individually with you as author, but changing the commit messages to match project requirements.
Let me know if you want to maintain the module directly, we can grant you write access to the repository.
If yes, be sure for future commits you follow the guidelines from:
* http://www.kamailio.org/wiki/devel/git-commit-guidelines
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/52#issuecomment-72487537
I will issue pull request again if changes will be needed, no need for write access.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/52#issuecomment-72490232
Closed #52.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/52#event-229333215
I pushed the new module to kamailio repository.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/52#issuecomment-72671722
-
Daniel-Constantin Mierla -
Sergey Okhapkin
-
sokhapkin