Add asynchronous support for sipcapture module You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/396
-- Commit Summary --
* Add async insert support
-- File Changes --
M modules/sipcapture/README (5) M modules/sipcapture/doc/sipcapture_admin.xml (51) M modules/sipcapture/sipcapture.c (608)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/396.patch https://github.com/kamailio/kamailio/pull/396.diff
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/396
HI, thanks for your patch, but can you please recreate it ? I see a lot diffs for tabs and \r\n, therefore very hard to read it and find changes.
thank you again.
regards, Alexandr
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/396#issuecomment-156056890
Re-formatting the code and/or indentation has to be a separate patch.
When the patch is recreated, follow the guidelines for commit message presented at:
* http://www.kamailio.org/wiki/devel/github-contributions#commit_message_forma...
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/396#issuecomment-156058273
So, i need to make new pull request with last commit?
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/396#issuecomment-156079982
yes please
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/396#issuecomment-156080081
Closed #396.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/396#event-462355498
-
Alexandr Dubovikov -
Daniel-Constantin Mierla
-
Konstantin Tumalevich