We use enum_query() to dispatch calls over a set of gateways. In our case single digits (for instance "8") can be a valid direct dial number which we would like to through against our enum server.
(This is an update of #593, now with guideline formatted commit messages.) You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/594
-- Commit Summary --
* enum: single digit is valid in function enum_query * enum: print out malformed uri in enum_query()
-- File Changes --
M modules/enum/enum.c (11)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/594.patch https://github.com/kamailio/kamailio/pull/594.diff
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/594
Have you checked what the ENUM rfc says?
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/594#issuecomment-216227169
I think from e164 format point of view, single digit number is too short. But then, I think ENUM doesn't enforce a length, because it can be used out of classic telephony numbering plan.
I am fine to merge the patches, after all, the length can be checked in the config file if one wants to impose some restrictions about it.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/594#issuecomment-216245565
I would suggest a config option for accepting this - some users may rely on it generating an error condition
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/594#issuecomment-216246892
As a matter of fact, even the current version of allowing 2 digits is probably not an e164 number. The only country code that is one digit is US/Canada with '1', but then there is no real number in their numbering plan with just a single digit after the country code.
The patch for the code is to a part where it checks that the length is sufficient to be sure that accessing the char at position 0 (first char) is safe and it is '+'. Because after that is a FOR loop starting at positing 1 (second char) to see if there are digits.
It might be useful to add min/max_length restrictions, but is more or less not related to this patch (or better said, not only related to this part). That could be an enhancement.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/594#issuecomment-216250402
Merging this pull request. The limits can be added with a new set of patches.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/594#issuecomment-216663691
Merged #594.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/594#event-649419113
-
Daniel-Constantin Mierla -
Jonas
-
Olle E. Johansson