Module: kamailio Branch: master Commit: f07fc80df5f475606ac81c2885cbedbdb3dca438 URL: https://github.com/kamailio/kamailio/commit/f07fc80df5f475606ac81c2885cbedbd...
Author: Ovidiu Sas osas@voipembedded.com Committer: Ovidiu Sas osas@voipembedded.com Date: 2017-03-01T16:03:19-05:00
htable: documentation fix for expires_column parameter
---
Modified: src/modules/htable/README Modified: src/modules/htable/doc/htable_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/f07fc80df5f475606ac81c2885cbedbd... Patch: https://github.com/kamailio/kamailio/commit/f07fc80df5f475606ac81c2885cbedbd...
The README file should not be generated anymore locally and pushed to git (because it can change completely the formatting based on local settings). It is done by a job on the server. You have to change and commit only the xml docbook files.
Cheers, Daniel
On 01/03/2017 22:04, Ovidiu Sas wrote:
Module: kamailio Branch: master Commit: f07fc80df5f475606ac81c2885cbedbdb3dca438 URL: https://github.com/kamailio/kamailio/commit/f07fc80df5f475606ac81c2885cbedbd...
Author: Ovidiu Sas osas@voipembedded.com Committer: Ovidiu Sas osas@voipembedded.com Date: 2017-03-01T16:03:19-05:00
htable: documentation fix for expires_column parameter
Modified: src/modules/htable/README Modified: src/modules/htable/doc/htable_admin.xml
Diff: https://github.com/kamailio/kamailio/commit/f07fc80df5f475606ac81c2885cbedbd... Patch: https://github.com/kamailio/kamailio/commit/f07fc80df5f475606ac81c2885cbedbd...
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
I didn't know that ... What should we do now?
-ovidiu
On Wed, Mar 1, 2017 at 4:10 PM, Daniel-Constantin Mierla miconda@gmail.com wrote:
The README file should not be generated anymore locally and pushed to git (because it can change completely the formatting based on local settings). It is done by a job on the server. You have to change and commit only the xml docbook files.
Cheers, Daniel
On 01/03/2017 22:04, Ovidiu Sas wrote:
Module: kamailio Branch: master Commit: f07fc80df5f475606ac81c2885cbedbdb3dca438 URL: https://github.com/kamailio/kamailio/commit/f07fc80df5f475606ac81c2885cbedbd...
Author: Ovidiu Sas osas@voipembedded.com Committer: Ovidiu Sas osas@voipembedded.com Date: 2017-03-01T16:03:19-05:00
htable: documentation fix for expires_column parameter
Modified: src/modules/htable/README Modified: src/modules/htable/doc/htable_admin.xml
Diff: https://github.com/kamailio/kamailio/commit/f07fc80df5f475606ac81c2885cbedbd... Patch: https://github.com/kamailio/kamailio/commit/f07fc80df5f475606ac81c2885cbedbd...
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
-- Daniel-Constantin Mierla www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training - Mar 6-8 (Europe) and Mar 20-22 (USA) - www.asipto.com Kamailio World Conference - May 8-10, 2017 - www.kamailioworld.com
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
It's not a real problem, nothing has to be done. It was just to inform and have in mind for the future.
In many cases the readme files create problems when trying to backport, due to different local setting for docbook on various distros for spacing, chapters, etc..., so a while ago we added a job running on server that generates and commits the readmes shortly after the docbook files are changed -- they show up as commits by kamailio.dev
Daniel
On 01/03/2017 22:16, Ovidiu Sas wrote:
I didn't know that ... What should we do now?
-ovidiu
On Wed, Mar 1, 2017 at 4:10 PM, Daniel-Constantin Mierla miconda@gmail.com wrote:
The README file should not be generated anymore locally and pushed to git (because it can change completely the formatting based on local settings). It is done by a job on the server. You have to change and commit only the xml docbook files.
Cheers, Daniel
On 01/03/2017 22:04, Ovidiu Sas wrote:
Module: kamailio Branch: master Commit: f07fc80df5f475606ac81c2885cbedbdb3dca438 URL: https://github.com/kamailio/kamailio/commit/f07fc80df5f475606ac81c2885cbedbd...
Author: Ovidiu Sas osas@voipembedded.com Committer: Ovidiu Sas osas@voipembedded.com Date: 2017-03-01T16:03:19-05:00
htable: documentation fix for expires_column parameter
Modified: src/modules/htable/README Modified: src/modules/htable/doc/htable_admin.xml
Diff: https://github.com/kamailio/kamailio/commit/f07fc80df5f475606ac81c2885cbedbd... Patch: https://github.com/kamailio/kamailio/commit/f07fc80df5f475606ac81c2885cbedbd...
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
-- Daniel-Constantin Mierla www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training - Mar 6-8 (Europe) and Mar 20-22 (USA) - www.asipto.com Kamailio World Conference - May 8-10, 2017 - www.kamailioworld.com
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Usually, I break documentation changes into two commits (for easy backporting). I don't know why I didn't do it this time (maybe because I haven't updated documentation in a long time).
Good to know about the server job. We should update the wiki with this info. Or maybe it is there and I missed it ...
-ovidiu
On Wed, Mar 1, 2017 at 4:37 PM, Daniel-Constantin Mierla miconda@gmail.com wrote:
It's not a real problem, nothing has to be done. It was just to inform and have in mind for the future.
In many cases the readme files create problems when trying to backport, due to different local setting for docbook on various distros for spacing, chapters, etc..., so a while ago we added a job running on server that generates and commits the readmes shortly after the docbook files are changed -- they show up as commits by kamailio.dev
Daniel
On 01/03/2017 22:16, Ovidiu Sas wrote:
I didn't know that ... What should we do now?
-ovidiu
On Wed, Mar 1, 2017 at 4:10 PM, Daniel-Constantin Mierla miconda@gmail.com wrote:
The README file should not be generated anymore locally and pushed to git (because it can change completely the formatting based on local settings). It is done by a job on the server. You have to change and commit only the xml docbook files.
Cheers, Daniel
On 01/03/2017 22:04, Ovidiu Sas wrote:
Module: kamailio Branch: master Commit: f07fc80df5f475606ac81c2885cbedbdb3dca438 URL: https://github.com/kamailio/kamailio/commit/f07fc80df5f475606ac81c2885cbedbd...
Author: Ovidiu Sas osas@voipembedded.com Committer: Ovidiu Sas osas@voipembedded.com Date: 2017-03-01T16:03:19-05:00
htable: documentation fix for expires_column parameter
Modified: src/modules/htable/README Modified: src/modules/htable/doc/htable_admin.xml
Diff: https://github.com/kamailio/kamailio/commit/f07fc80df5f475606ac81c2885cbedbd... Patch: https://github.com/kamailio/kamailio/commit/f07fc80df5f475606ac81c2885cbedbd...
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
-- Daniel-Constantin Mierla www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training - Mar 6-8 (Europe) and Mar 20-22 (USA) - www.asipto.com Kamailio World Conference - May 8-10, 2017 - www.kamailioworld.com
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
-- Daniel-Constantin Mierla www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio Advanced Training - Mar 6-8 (Europe) and Mar 20-22 (USA) - www.asipto.com Kamailio World Conference - May 8-10, 2017 - www.kamailioworld.com
-
Daniel-Constantin Mierla -
Ovidiu Sas