Not really using app_python, but still sort of don't like adding the "-fno-strict-aliasing" because it can hide bugs in other parts of module code, but if that's the only way as detailed in pep 3123 and nobody else finds a different solution, then can be merged. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/924#issuecomment-272296924

Merged #924. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/924#event-1266634930

@ezdev128 - any specific reason for this merge without clarifying the `-fno-strict-aliasing` concerns? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/924#issuecomment-332423978

@ezdev128 - the concern is that by doing this hack just to **not see** some known warnings due to external code, you hide eventual strict aliasing issues in the kamailio module code, so if one adds new code and mixes pointer types, it won't be any earning. This can cause unpredictable troubles at runtime. Anyhow, as I said in my previous comment, I am not using the module and if people other devs want it with this one, it's ok for me. But simply merging a PR with expressed concerns in comments without any details is not that good approach. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/924#issuecomment-332494443