@ezdev128 - the concern is that by doing this hack just to not see some known warnings due to external code, you hide eventual strict aliasing issues in the kamailio module code, so if one adds new code and mixes pointer types, it won't be any earning. This can cause unpredictable troubles at runtime.

Anyhow, as I said in my previous comment, I am not using the module and if people other devs want it with this one, it's ok for me. But simply merging a PR with expressed concerns in comments without any details is not that good approach.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.