ITNOA
<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description This PR remove `strings.h` and try to use standard functions. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4114
-- Commit Summary --
* Change C standard version to 23 * Remove strings.h * Fix some typo
-- File Changes --
M src/core/dprint.c (2) M src/core/parser/parse_methods.c (2) M src/core/parser/parse_option_tags.h (2) M src/core/sr_module.c (2) M src/core/ut.h (1)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4114.patch https://github.com/kamailio/kamailio/pull/4114.diff
@soroshsabz pushed 1 commit.
6b8cfeb73ae783273a1c291dc7cae481932e87d8 Add cross_strings.h
@soroshsabz pushed 1 commit.
a72cf4e0b6f8d78beefbde44ea573841aea8cbce Fix some typo
@soroshsabz pushed 1 commit.
ed73b74006f42b3c48ff260d5bd30fdd0dd5a30d Fix some typo
Hello, before going further this way you should start a discussion e.g. on the developer list or during one of the next online developer meetings. There will be many changes necessary to really support Windows, and right now I am not 100% sure if this is really a feasible thing to do that will work in the end. In the old Makefile structure there was some support for Cygwin, but I have never really seen this working or really used from somebody.
One other comment, it seems that you took the cross_strings.h file from some other project and then just replaced the copyright notice with your company (commits 6b8cfeb73a and ed73b74). This is in my opinion not how we should work in this project with regards to other copyrighted files.
@henningw thanks for review my PR, `cross_strings.h` come from [our company](https://github.com/BSVN), I can change copyright with anything that you want. (_That change was because the previous one was outdated and now we are making changes to the new company brand name_)
github-actions[bot] left a comment (kamailio/kamailio#4114)
This PR is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.
Closed #4114.