#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
This is the selectors feature for `lost` module. The module still in development but the core functionality is working. What need to do 1. separate feature into dedicated `.c` file; 2. rebase on current `lost` implementation; 3. add documentation; 4. add a unit test.
Would be fine if we can merge this into 5.5.
This branch based on e7d68556e3560f488c4f421731f78b3f9abe549e commit
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2705
-- Commit Summary --
* http_client: http_client_request (api) content-type header support * lost: new features, attributes and a new function to dereference location * lost: bug-fix due to a code formatting error * lost: DOM level count fix * http_client: duplicated code removed * lost: README update * lost: memory leak fix and code refactoring * lost: implemented sectors
-- File Changes --
M src/modules/http_client/curl_api.c (1) M src/modules/http_client/curl_api.h (3) M src/modules/http_client/functions.c (30) M src/modules/http_client/functions.h (14) M src/modules/lost/doc/lost.xml (2) M src/modules/lost/doc/lost_admin.xml (172) M src/modules/lost/functions.c (921) M src/modules/lost/functions.h (3) M src/modules/lost/lost.c (754) A src/modules/lost/naptr.c (255) A src/modules/lost/naptr.h (38) M src/modules/lost/pidf.c (5) A src/modules/lost/response.c (991) A src/modules/lost/response.h (131) M src/modules/lost/utilities.c (532) M src/modules/lost/utilities.h (65)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2705.patch https://github.com/kamailio/kamailio/pull/2705.diff
First, you have to rebase and do fast-forward, because it looks like (re-)merging commits done earlier.
However, this PR seems to introduce new code and features, unrelated to fixing bugs in existing code or completing the features of specs. Being already within testing phase for 5.5, this PR should wait for master to be unfrozen, then merge, so it will be in 5.6.
@sergey-safarov pushed 2 commits.
0a624c9c001d2903599b93281bc84a1221a62f4e removed typos 3a33c7c430a0208e0bca3f9802384dc030b0302a replased own code to get_body_part_by_filter
I am glad that the function of the `lost` module is extended. Just a small note: - according to the latest version of NENA i3, the Call-Info header purpose changes from nena-xxx to emergency-xxx (e.g. nena-IncidentId will be replaced by emergency-IncidentId); perhaps this can already be taken into account. - do we need a new release every time new selectors are needed? For instance in Europe we can have `purpose=EmergencyCallData.eCall.MSD` when NG eCall is rolled out. Refer to [RFC 8147](https://tools.ietf.org/html/rfc8147)
according to the latest version of NENA i3, the Call-Info header purpose changes from nena-xxx to emergency-xxx (e.g. nena-IncidentId will be replaced by emergency-IncidentId); perhaps this can already be taken into account.
Think we need a write a function to convert headers to required format like ``` cast_nena_headers_prefix("nena-"); cast_nena_headers_prefix("emergency-"); ```
do we need a new release every time new selectors are needed? For instance in Europe we can have purpose=EmergencyCallData.eCall.MSD when NG eCall is rolled out.
RFC documents not changed rarely. I think we can add a selector for this RFC also like ``` @lost.emergency_call_data.ecall_msd; ```
Whenever this PR is ready to merge, it should be done with `Squash and Merge`, because some commits do not have the commit message formatted as per contributing guidelines.
yes, we expect several additional commits (docs, tests). And then rebase + quash.
@sergey-safarov last update was some weeks ago, is there any update, e.g. its ready for review etc..?
@sergey-safarov pushed 1 commit.
477e3f1652f2fed9873f4bbd938b862ce27aca16 Fixed error messages like "sel_hdrs(): cannot allocate static buffer"
@sergey-safarov last update was some months ago, is this still work in progress?
Hi Henning Yes, this work in progress. Dev is not available now. Sorry, for so long delay.
@sergey-safarov any news? Just wanted to ask because the freeze date for the next kamailio version is upcoming.
@sergey-safarov any update from your side? Thank you.
This PR is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.
@sergey-safarov the PR is still in draft status, not sure about the status. If it will be not completed for some reasons, just let us know.
This PR is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.
Closed #2705.
-
Daniel-Constantin Mierla -
github-actions[bot]
-
Henning Westerholt
-
sergey-safarov
-
Wolfgang Kampichler