[kamailio] Registrar: kamailio update contact infomation failed but it sends 200-register message to client (#497)
Hi,
When client send register message that reg-id in contact is "0", kamailio failed to update contacts info， but it will send 200-register to client, this will cause one issue that no one can find this client(will always be 404 error)
reg-id in message: Contact: sip:2015@100080:5060;ob;reg-id=0 Related logs: /usr/local/sbin/kamailio[30325]: ERROR: registrar [savec:402]: pack_ci(): invalid reg-id value /usr/local/sbin/kamailio[30325]: ERROR: registrar [savec:685]: update_contacts(): failed to pack contact specific info
I think registrar should reply 4xx message when reg-id's value is 0
Best Regards, Shengy
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/497
If I am not mistaken, Reg-ID 0 is invalid. RFC 5626 says
c-p-reg = "reg-id" EQUAL 1*DIGIT ; 1 to (2^31 - 1)
I think a 439 message, like a reg-id doesn't exist is appropriate. Sending 200 Ok is definitely wrong.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/497#issuecomment-181252994
I‘m agree with oej's opinion.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/497#issuecomment-181716682
439 seems to be associated with the fact that the server has no outbound support, which is not the case here. After some checking I ended up selecting 400 with custom response text -- see the commit linked above.
Testing and reporting the results would be very appreciated.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/497#issuecomment-183080403
Sorry, please could anyone tell me how to download the patch and apply it to kamailio source project. I just want to test the patch, thank you.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/497#issuecomment-184091909
@shenya the patch is now also in branch 4.3 and it will be part in v4.3.5 release. Otherwise, you can cherry pick it with git command if you clone the repository from github. If you look in sr-dev mailing list archive for the notification email of this commit, you will find the links to diff and patch variants of the commit.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/497#issuecomment-190970976
Closing, the issue being fixed.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/497#issuecomment-190971016
Closed #497.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/497#event-573892864
-
Daniel-Constantin Mierla -
Olle E. Johansson
-
szkbsgy