Module: sip-router Branch: master Commit: e2bd2192b5ddc33d0e8fd486467842d9cceda131 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e2bd2192...
Author: Olle E. Johansson oej@edvina.net Committer: Olle E. Johansson oej@edvina.net Date: Sat Mar 30 09:10:02 2013 +0100
stun Add clarification to the README
And a big thank you to Peter Dunkley and Crocodile RCS for doing the work involved in making this a module, instead of a compile time options. Modules are cool. And easier to handle by pre-compiled distributions/packages.
---
modules/stun/README | 7 ++++--- modules/stun/doc/stun_admin.xml | 3 ++- 2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/modules/stun/README b/modules/stun/README index 5d223fe..e887ff6 100644 --- a/modules/stun/README +++ b/modules/stun/README @@ -4,9 +4,9 @@ Peter Dunkley
Crocodile RCS Ltd
- Copyright © 2012 Crocodile RCS Ltd + Copyright � 2012 Crocodile RCS Ltd
- Copyright © 2001-2003 FhG Fokus + Copyright � 2001-2003 FhG Fokus __________________________________________________________________
Table of Contents @@ -40,7 +40,8 @@ Chapter 1. Admin Guide 1. Overview
This module provides limited STUN server (RFC 5389) support for - Kamailio. + Kamailio. It's built for providing STUN support in the SIP signalling + channel, not being a standalone STUN/TURN server.
2. Dependencies
diff --git a/modules/stun/doc/stun_admin.xml b/modules/stun/doc/stun_admin.xml index 5aa9bd5..d08194c 100644 --- a/modules/stun/doc/stun_admin.xml +++ b/modules/stun/doc/stun_admin.xml @@ -16,7 +16,8 @@ <section> <title>Overview</title> <para>This module provides limited STUN server (RFC 5389) support for - &kamailio;.</para> + &kamailio;. It's built for providing STUN support in the SIP signalling + channel, not being a standalone STUN/TURN server.</para> </section>
<section>
I think the commit messages should stay rather technical, specific to the changed parts. Credits for anyone contributing somehow to the commit by reporting the issue, troubleshooting or providing a patch must be done. But for more the public mailing lists should be used.
There are many people scanning the git-log for understanding the changes, it would be good not to get it loaded with unrelated content. Thanks are really appreciated, but not mixed where something else should be.
Cheers, Daniel
On 3/30/13 9:11 AM, Olle E. Johansson wrote:
Module: sip-router Branch: master Commit: e2bd2192b5ddc33d0e8fd486467842d9cceda131 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e2bd2192...
Author: Olle E. Johansson oej@edvina.net Committer: Olle E. Johansson oej@edvina.net Date: Sat Mar 30 09:10:02 2013 +0100
stun Add clarification to the README
And a big thank you to Peter Dunkley and Crocodile RCS for doing the work involved in making this a module, instead of a compile time options. Modules are cool. And easier to handle by pre-compiled distributions/packages.
modules/stun/README | 7 ++++--- modules/stun/doc/stun_admin.xml | 3 ++- 2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/modules/stun/README b/modules/stun/README index 5d223fe..e887ff6 100644 --- a/modules/stun/README +++ b/modules/stun/README @@ -4,9 +4,9 @@ Peter Dunkley
Crocodile RCS Ltd
- Copyright © 2012 Crocodile RCS Ltd
- Copyright ? 2012 Crocodile RCS Ltd
- Copyright © 2001-2003 FhG Fokus
Copyright ? 2001-2003 FhG Fokus __________________________________________________________________
Table of Contents
@@ -40,7 +40,8 @@ Chapter 1. Admin Guide
Overview
This module provides limited STUN server (RFC 5389) support for
- Kamailio.
Kamailio. It's built for providing STUN support in the SIP signalling
channel, not being a standalone STUN/TURN server.
- Dependencies
diff --git a/modules/stun/doc/stun_admin.xml b/modules/stun/doc/stun_admin.xml index 5aa9bd5..d08194c 100644 --- a/modules/stun/doc/stun_admin.xml +++ b/modules/stun/doc/stun_admin.xml @@ -16,7 +16,8 @@
<section> <title>Overview</title> <para>This module provides limited STUN server (RFC 5389) support for - &kamailio;.</para> + &kamailio;. It's built for providing STUN support in the SIP signalling + channel, not being a standalone STUN/TURN server.</para> </section>
<section>
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
30 mar 2013 kl. 12:00 skrev Daniel-Constantin Mierla miconda@gmail.com:
I think the commit messages should stay rather technical, specific to the changed parts. Credits for anyone contributing somehow to the commit by reporting the issue, troubleshooting or providing a patch must be done. But for more the public mailing lists should be used.
There are many people scanning the git-log for understanding the changes, it would be good not to get it loaded with unrelated content. Thanks are really appreciated, but not mixed where something else should be.
Ok! /O
Cheers, Daniel
On 3/30/13 9:11 AM, Olle E. Johansson wrote:
Module: sip-router Branch: master Commit: e2bd2192b5ddc33d0e8fd486467842d9cceda131 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=e2bd2192...
Author: Olle E. Johansson oej@edvina.net Committer: Olle E. Johansson oej@edvina.net Date: Sat Mar 30 09:10:02 2013 +0100
stun Add clarification to the README
And a big thank you to Peter Dunkley and Crocodile RCS for doing the work involved in making this a module, instead of a compile time options. Modules are cool. And easier to handle by pre-compiled distributions/packages.
modules/stun/README | 7 ++++--- modules/stun/doc/stun_admin.xml | 3 ++- 2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/modules/stun/README b/modules/stun/README index 5d223fe..e887ff6 100644 --- a/modules/stun/README +++ b/modules/stun/README @@ -4,9 +4,9 @@ Peter Dunkley
Crocodile RCS Ltd
- Copyright © 2012 Crocodile RCS Ltd
- Copyright � 2012 Crocodile RCS Ltd
- Copyright © 2001-2003 FhG Fokus
Copyright � 2001-2003 FhG Fokus __________________________________________________________________
Table of Contents
@@ -40,7 +40,8 @@ Chapter 1. Admin Guide
Overview
This module provides limited STUN server (RFC 5389) support for
- Kamailio.
- Kamailio. It's built for providing STUN support in the SIP signalling
- channel, not being a standalone STUN/TURN server.
- Dependencies
diff --git a/modules/stun/doc/stun_admin.xml b/modules/stun/doc/stun_admin.xml index 5aa9bd5..d08194c 100644 --- a/modules/stun/doc/stun_admin.xml +++ b/modules/stun/doc/stun_admin.xml @@ -16,7 +16,8 @@
<section> <title>Overview</title> <para>This module provides limited STUN server (RFC 5389) support for - &kamailio;.</para> + &kamailio;. It's built for providing STUN support in the SIP signalling + channel, not being a standalone STUN/TURN server.</para> </section>
<section>
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
-- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio World Conference, April 16-17, 2013, Berlin
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
-
Daniel-Constantin Mierla -
Olle E. Johansson