Module: sip-router Branch: master Commit: 014d1000055d8ee93ef35336b1701674fe23a675 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=014d1000...
Author: Peter Dunkley peter.dunkley@crocodile-rcs.com Committer: Peter Dunkley peter.dunkley@crocodile-rcs.com Date: Wed Oct 31 17:48:17 2012 +0000
core: corrected some mis-leading error messages
---
msg_translator.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/msg_translator.c b/msg_translator.c index 0447bfa..6985418 100644 --- a/msg_translator.c +++ b/msg_translator.c @@ -1722,8 +1722,7 @@ char * build_req_buf_from_sip_req( struct sip_msg* msg, if (unlikely(via_anchor==0)) goto error00; line_buf = create_via_hf( &via_len, msg, send_info, &branch); if (unlikely(!line_buf)){ - LOG(L_ERR,"ERROR: build_req_buf_from_sip_req: " - "memory allocation failure\n"); + LM_WARN("creating Via header\n"); goto error00; } after_local_via: @@ -2496,7 +2495,8 @@ char* via_builder( unsigned int *len, }
if (con == NULL) { - LM_WARN("TCP/TLS connection for WebSocket could not be found\n"); + LM_WARN("TCP/TLS connection (id: %d) for WebSocket could not be found\n" + send_info->id); return 0; }
Am Mittwoch, 31. Oktober 2012, 19:06:46 schrieb Peter Dunkley:
core: corrected some mis-leading error messages
msg_translator.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/msg_translator.c b/msg_translator.c index 0447bfa..6985418 100644 --- a/msg_translator.c +++ b/msg_translator.c @@ -1722,8 +1722,7 @@ char * build_req_buf_from_sip_req( struct sip_msg* msg, if (unlikely(via_anchor==0)) goto error00; line_buf = create_via_hf( &via_len, msg, send_info, &branch); if (unlikely(!line_buf)){
LOG(L_ERR,"ERROR: build_req_buf_from_sip_req: ""memory allocation failure\n");
LM_WARN("creating Via header\n");
Hello Peter,
I must admit that I don't understand this log message now. If I understand the code correctly then the LM_WARN is printed when no VIA header field could be created and execution is stopped. So I'd suggest that we use
LM_ERR("could not create Via header\n");
instead of your change.
Best regards,
Henning Westerholt
Hi Henning,
Re-reading this I agree - my error message isn't helpful.
I am out of the office in Berlin right now and might not have time to change it until later in the week.
Thanks,
Peter
Am Mittwoch, 31. Oktober 2012, 19:06:46 schrieb Peter Dunkley:
core: corrected some mis-leading error messages
msg_translator.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/msg_translator.c b/msg_translator.c index 0447bfa..6985418 100644 --- a/msg_translator.c +++ b/msg_translator.c @@ -1722,8 +1722,7 @@ char * build_req_buf_from_sip_req( struct sip_msg* msg, if (unlikely(via_anchor==0)) goto error00; line_buf = create_via_hf( &via_len, msg, send_info, &branch); if (unlikely(!line_buf)){
LOG(L_ERR,"ERROR: build_req_buf_from_sip_req: ""memory allocation failure\n");
LM_WARN("creating Via header\n");Hello Peter,
I must admit that I don't understand this log message now. If I understand the code correctly then the LM_WARN is printed when no VIA header field could be created and execution is stopped. So I'd suggest that we use
LM_ERR("could not create Via header\n");
instead of your change.
Best regards,
Henning Westerholt
-
Henning Westerholt -
Peter Dunkley