- Added new sms pdu data: originating & destination address flags; SCTS(DELIVER)/VP(SUBMIT) absolute time format. - decode_3gpp_sms(): added support for DELIVER type; Added VP-AbsoluteTimeFormat for SUBMIT type. - pv_sms_body(): added support for ucs2 coding. - Extends of pv_get_sms() and pv_set_sms(): added support for originating & destination address flags.
<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2702
-- Commit Summary --
* smsops: Imrovements in decode_3gpp_sms() and pv_sms_body()
-- File Changes --
M src/modules/smsops/smsops_impl.c (343)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2702.patch https://github.com/kamailio/kamailio/pull/2702.diff
@alexyosifov - is this PR fixing the current behaviour and making it to work according to specs? Trying to figure out how this should be merged.
@miconda - the changes were made according to spec. Added more parameters that can be set/get from the config files.
Merged #2702 into master.