Module: sip-router Branch: master Commit: 573c9031a44168df356818f572f10f69791a1458 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=573c9031...
Author: Victor Seva linuxmaniac@torreviejawireless.org Committer: Victor Seva linuxmaniac@torreviejawireless.org Date: Tue Aug 27 00:03:49 2013 +0200
permissions: fix ws support on allow_trusted function.
---
modules/permissions/trusted.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/modules/permissions/trusted.c b/modules/permissions/trusted.c index ef79dc7..78c0b1e 100644 --- a/modules/permissions/trusted.c +++ b/modules/permissions/trusted.c @@ -512,7 +512,7 @@ int allow_trusted_2(struct sip_msg* _msg, char* _src_ip_sp, char* _proto_sp) return -1; }
- if(proto.len!=3 && proto.len!=4) + if(proto.len<2 && proto.len>4) goto error;
switch(proto.s[0]) {
On Tuesday 27 August 2013, Victor Seva wrote:
- if(proto.len!=3 && proto.len!=4)
- if(proto.len<2 && proto.len>4) goto error;
This is wrong, the condition will never match. You probably want to use || instead of &&.
On 27 Aug 2013 08:09, "Alex Hermann" alex@speakup.nl wrote:
On Tuesday 27 August 2013, Victor Seva wrote:
- if(proto.len!=3 && proto.len!=4)
- if(proto.len<2 && proto.len>4) goto error;
This is wrong, the condition will never match. You probably want to use || instead of &&.
Yes. My mistake. I will try to change it as soon as I get home.
Thanks
-
Alex Hermann -
Victor Seva