Module: sip-router Branch: master Commit: 039c72b1f01f26e7a873e4db9985ad5d4d9178c9 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=039c72b1...
Author: Peter Dunkley peter.dunkley@crocodile-rcs.com Committer: Peter Dunkley peter.dunkley@crocodile-rcs.com Date: Thu Apr 19 18:11:33 2012 +0100
lib/srdb1/schema, utils/kamctl: Updated DB schemas for presence and RLS
- New fields for from_user and from_domain as these may be different to the watcher_user and watcher_domain now.
---
lib/srdb1/schema/pr_active_watchers.xml | 16 +++++++++++++++- lib/srdb1/schema/rls_watchers.xml | 14 ++++++++++++++ utils/kamctl/db_berkeley/kamailio/active_watchers | 4 ++-- utils/kamctl/db_berkeley/kamailio/rls_watchers | 4 ++-- utils/kamctl/db_berkeley/kamailio/version | 4 ++-- utils/kamctl/db_sqlite/presence-create.sql | 4 +++- utils/kamctl/db_sqlite/rls-create.sql | 2 ++ utils/kamctl/dbtext/kamailio/active_watchers | 2 +- utils/kamctl/dbtext/kamailio/rls_watchers | 2 +- utils/kamctl/dbtext/kamailio/version | 4 ++-- utils/kamctl/mysql/presence-create.sql | 4 +++- utils/kamctl/mysql/rls-create.sql | 2 ++ utils/kamctl/oracle/presence-create.sql | 4 +++- utils/kamctl/oracle/rls-create.sql | 2 ++ utils/kamctl/postgres/presence-create.sql | 4 +++- utils/kamctl/postgres/rls-create.sql | 2 ++ 16 files changed, 59 insertions(+), 15 deletions(-)
Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=039c...
Peter Dunkley writes:
lib/srdb1/schema, utils/kamctl: Updated DB schemas for presence and RLS
- New fields for from_user and from_domain as these may be different to the watcher_user and watcher_domain now.
this commit update version of active_watchers table, but didn't update version of rls_watchers although same fields were added to both.
could you also increase rls_watchers version?
-- juha
Hi,
The version of rls_watchers had already been increased in master within the past couple of weeks. Does it need to be increased again?
Peter
On 22 Apr 2012, at 08:21, Juha Heinanen jh@tutpro.com wrote:
Peter Dunkley writes:
lib/srdb1/schema, utils/kamctl: Updated DB schemas for presence and RLS
- New fields for from_user and from_domain as these may be different
to the watcher_user and watcher_domain now.
this commit update version of active_watchers table, but didn't update version of rls_watchers although same fields were added to both.
could you also increase rls_watchers version?
-- juha
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Peter Dunkley writes:
The version of rls_watchers had already been increased in master within the past couple of weeks. Does it need to be increased again?
peter,
if someone updates tables only once after a new version of sip router has been released, then one update of table version numbers is ok.
i have been continuously testing master and rls_watchers version number was increased when updated field was added to it. then two new fields were added by this patch without increasing version number. that makes my upgrade script more complex, because now it does not suffice that it check table version number to find out if upgrade needs to be done. it also needs to check if certain fields already exist in the table. for this reason i would prefer that also during development phase table version numbers are increased each time a change is made.
-- juha
OK. I will do it some time early next week when I am back in the office.
Peter
On 22 Apr 2012, at 09:52, Juha Heinanen jh@tutpro.com wrote:
Peter Dunkley writes:
The version of rls_watchers had already been increased in master within the past couple of weeks. Does it need to be increased again?
peter,
if someone updates tables only once after a new version of sip router has been released, then one update of table version numbers is ok.
i have been continuously testing master and rls_watchers version number was increased when updated field was added to it. then two new fields were added by this patch without increasing version number. that makes my upgrade script more complex, because now it does not suffice that it check table version number to find out if upgrade needs to be done. it also needs to check if certain fields already exist in the table. for this reason i would prefer that also during development phase table version numbers are increased each time a change is made.
-- juha
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Hi,
I've updated the rls_watchers table number and pushed the change into git.
Peter
On Sun, 2012-04-22 at 11:52 +0300, Juha Heinanen wrote:
Peter Dunkley writes:
The version of rls_watchers had already been increased in master within the past couple of weeks. Does it need to be increased again?
peter,
if someone updates tables only once after a new version of sip router has been released, then one update of table version numbers is ok.
i have been continuously testing master and rls_watchers version number was increased when updated field was added to it. then two new fields were added by this patch without increasing version number. that makes my upgrade script more complex, because now it does not suffice that it check table version number to find out if upgrade needs to be done. it also needs to check if certain fields already exist in the table. for this reason i would prefer that also during development phase table version numbers are increased each time a change is made.
-- juha
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
-
Juha Heinanen -
Peter Dunkley