<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #4174
#### Description Extend the return value of dns_cache_print_entry with the parameter `rr_skip_record` for NAPTR records. The parameter `rr_skip_record` indicates, whether the NAPTR record is skipped due to issues reaching the destinations. Once a NAPTR record is marked as skipped, it will no longer be used.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/4175
-- Commit Summary --
* core: Include parameter skip_record in dns_cache_print_entry
-- File Changes --
M src/core/dns_cache.c (7)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4175.patch https://github.com/kamailio/kamailio/pull/4175.diff
henningw left a comment (kamailio/kamailio#4175)
Thanks for the PR. The format check is failing, so this needs to be fixed (e.g. by running clang-format and then force-push the commit).
@schneuwlym pushed 1 commit.
73789e319064ccb4b1a24f357a268733b75c9d1a core: Include parameter skip_record in dns_cache_print_entry
schneuwlym left a comment (kamailio/kamailio#4175)
Thanks for the PR. The format check is failing, so this needs to be fixed (e.g. by running clang-format and then force-push the commit).
Should be fixed now. I had to setup the dev container and configure my VS Code to format it on save.
henningw left a comment (kamailio/kamailio#4175)
Thanks. Lets wait a bit for eventual other feedback and then it will be merged.