5 Oct
2021
5 Oct
'21
2:48 p.m.
Hello all,
the handling of timer events is broken in 5.5.2. I get the following error:
ERROR: <core> [core/parser/msg_parser.c:748]: parse_msg(): ERROR: parse_msg:
message=<GET /timer HTTP/0.9#012#012>
I think it was introduced by
https://github.com/kamailio/kamailio/commit/1737e9443d6617350c5e6044aef07be…
<https://github.com/kamailio/kamailio/commit/1737e9443d6617350c5e6044aef07be565a345d0#diff-097939cfb9b6af2960a0d1161620155feadf3cbb4898144dee10b22834620a72>
...
skip:
msg->unparsed=tmp;
if(msg->headers==NULL) {
/* nothing parsed - invalid input sip message */
goto error1;
}
…
Should’t thy be handled different already in parse_msg in msg_parser.c?
Thanks and regards
Markus
5 Oct
5 Oct
3:29 p.m.
Hello,
that's a HTTP request to be handled, normally it should go to the
event_route[xhttp:request] block with xhttp module loaded, as the
internal design is supposed to work right now. Timer module comes from
SER project, so I am not familiar with it. In Kamailio, we worked with
rtimer module.
Anyhow, I pushed a patch to add one header to that internal HTTP request:
*
https://github.com/kamailio/kamailio/commit/c3629f877500373028d2c7cdefd976c…
Can you try it to see if works now? If yes, I can backport, but it may
be better to switch to a SIP message instead of HTTP, seems awkward for
the purpose of this module, but again, I am not really familiar with
this module.
Cheers,
Daniel
On 05.10.21 13:48, Markus Bönke wrote:
Hello all,
the handling of timer events is broken in 5.5.2. I get the following
error:
ERROR: <core> [core/parser/msg_parser.c:748]: parse_msg(): ERROR:
parse_msg: message=<GET /timer HTTP/0.9#012#012>
I think it was introduced by
https://github.com/kamailio/kamailio/commit/1737e9443d6617350c5e6044aef07be…
<https://github.com/kamailio/kamailio/commit/1737e9443d6617350c5e6044aef07be565a345d0#diff-097939cfb9b6af2960a0d1161620155feadf3cbb4898144dee10b22834620a72>
...
skip:
msg->unparsed=tmp;
if(msg->headers==NULL) {
/* nothing parsed - invalid input sip message */
goto error1;
}
…
Should’t thy be handled different already in parse_msg in msg_parser.c?
Thanks and regards
Markus
_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev(a)lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
--
Daniel-Constantin Mierla -- www.asipto.com
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio Advanced Training - Online
Nov 08-11, 2021 (Europe Timezone) - Nov 22-25, 2021 (America Timezone)
* https://www.asipto.com/sw/kamailio-advanced-training-online/
5:25 p.m.
Hallo Daniel,
thanks for the quick fix! I’ve tested your patch - it works for me, you can merge and
backport if you want. I’ll change my script to use the rtime module.
Best regards
Markus
Am 05.10.2021 um 14:29 schrieb Daniel-Constantin
Mierla <miconda(a)gmail.com>om>:
Hello,
that's a HTTP request to be handled, normally it should go to the
event_route[xhttp:request] block with xhttp module loaded, as the internal design is
supposed to work right now. Timer module comes from SER project, so I am not familiar with
it. In Kamailio, we worked with rtimer module.
Anyhow, I pushed a patch to add one header to that internal HTTP request:
* https://github.com/kamailio/kamailio/commit/c3629f877500373028d2c7cdefd976c…
<https://github.com/kamailio/kamailio/commit/c3629f877500373028d2c7cdefd976cddda31c15>
Can you try it to see if works now? If yes, I can backport, but it may be better to
switch to a SIP message instead of HTTP, seems awkward for the purpose of this module, but
again, I am not really familiar with this module.
Cheers,
Daniel
On 05.10.21 13:48, Markus Bönke wrote:
Hello all,
the handling of timer events is broken in 5.5.2. I get the following error:
ERROR: <core> [core/parser/msg_parser.c:748]: parse_msg(): ERROR: parse_msg:
message=<GET /timer HTTP/0.9#012#012>
I think it was introduced by
https://github.com/kamailio/kamailio/commit/1737e9443d6617350c5e6044aef07be…
<https://github.com/kamailio/kamailio/commit/1737e9443d6617350c5e6044aef07be565a345d0#diff-097939cfb9b6af2960a0d1161620155feadf3cbb4898144dee10b22834620a72>
...
skip:
msg->unparsed=tmp;
if(msg->headers==NULL) {
/* nothing parsed - invalid input sip message */
goto error1;
}
…
Should’t thy be handled different already in parse_msg in msg_parser.c?
Thanks and regards
Markus
_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev(a)lists.kamailio.org <mailto:sr-dev@lists.kamailio.org>
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
<https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev>
--
Daniel-Constantin Mierla -- www.asipto.com <http://www.asipto.com/>
www.twitter.com/miconda <http://www.twitter.com/miconda> --
www.linkedin.com/in/miconda <http://www.linkedin.com/in/miconda>
Kamailio Advanced Training - Online
Nov 08-11, 2021 (Europe Timezone) - Nov 22-25, 2021 (America Timezone)
* https://www.asipto.com/sw/kamailio-advanced-training-online/
<https://www.asipto.com/sw/kamailio-advanced-training-online/>
5:38 p.m.
Hello,
patch backported to 5.5 branch.
Cheers,
Daniel
On 05.10.21 16:25, Markus Bönke wrote:
Hallo Daniel,
thanks for the quick fix! I’ve tested your patch - it works for me,
you can merge and backport if you want. I’ll change my script to use
the rtime module.
Best regards
Markus
--
Daniel-Constantin Mierla -- www.asipto.com
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio Advanced Training - Online
Nov 08-11, 2021 (Europe Timezone) - Nov 22-25, 2021 (America Timezone)
* https://www.asipto.com/sw/kamailio-advanced-training-online/
Am 05.10.2021 um 14:29 schrieb Daniel-Constantin
Mierla
<miconda(a)gmail.com <mailto:miconda@gmail.com>>:
Hello,
that's a HTTP request to be handled, normally it should go to the
event_route[xhttp:request] block with xhttp module loaded, as the
internal design is supposed to work right now. Timer module comes
from SER project, so I am not familiar with it. In Kamailio, we
worked with rtimer module.
Anyhow, I pushed a patch to add one header to that internal HTTP request:
*
https://github.com/kamailio/kamailio/commit/c3629f877500373028d2c7cdefd976c…
Can you try it to see if works now? If yes, I can backport, but it
may be better to switch to a SIP message instead of HTTP, seems
awkward for the purpose of this module, but again, I am not really
familiar with this module.
Cheers,
Daniel
On 05.10.21 13:48, Markus Bönke wrote:
Hello all,
the handling of timer events is broken in 5.5.2. I get the following
error:
ERROR: <core> [core/parser/msg_parser.c:748]: parse_msg(): ERROR:
parse_msg: message=<GET /timer HTTP/0.9#012#012>
I think it was introduced by
https://github.com/kamailio/kamailio/commit/1737e9443d6617350c5e6044aef07be…
<https://github.com/kamailio/kamailio/commit/1737e9443d6617350c5e6044aef07be565a345d0#diff-097939cfb9b6af2960a0d1161620155feadf3cbb4898144dee10b22834620a72>
...
skip:
msg->unparsed=tmp;
if(msg->headers==NULL) {
/* nothing parsed - invalid input sip message */
goto error1;
}
…
Should’t thy be handled different already in parse_msg in msg_parser.c?
Thanks and regards
Markus
_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev(a)lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
--
Daniel-Constantin Mierla -- www.asipto.com
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio Advanced Training - Online
Nov 08-11, 2021 (Europe Timezone) - Nov 22-25, 2021 (America Timezone)
* https://www.asipto.com/sw/kamailio-advanced-training-online/
1174
days inactive
1174
days old
3 comments
2 participants
participants (2)
-
Daniel-Constantin Mierla -
Markus Bönke