[kamailio/kamailio] Make tcp_check_timer default to depend on tcp_msg_data_timeout and tcp_msg_read_timeout values (PR #3608)
If `tcp_check_timer` is not set, use default value that is half of `tcp_msg_data_timeout` or `tcp_msg_read_timeout` value depending on which one is smaller and not zero.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3608
-- Commit Summary --
* Make tcp_check_timer default to depend on tcp_msg_data_timeout and
-- File Changes --
M src/main.c (22)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3608.patch https://github.com/kamailio/kamailio/pull/3608.diff
@juha-h pushed 1 commit.
38a1c736fa3ebef8827a0f3ef645e7e4fa165b5a Trying to fix format
Don't know why `check-format (pull_request)` failed again, because latest commit 38a1c736fa3ebef8827a0f3ef645e7e4fa165b5a... PASSED.
I am going to apply it manually, because the commit message is not following the contributing guidelines.
Closed #3608.
I guess clang format may differ based on clang version and maybe global defaults on OSes -- the check here should be taken as a soft recommendation, but if it looks pretty ok, it can be merged.
Anyhow, in this particular case I merged manually, closing this one..
Don't know why `check-format (pull_request)` failed again, because latest commit [38a1c73](https://github.com/kamailio/kamailio/commit/38a1c736fa3ebef8827a0f3ef645e7e4...)... PASSED.
yes, the action checks if *all* commits follows the clang-format not the final result. That is why rebase and squash is a better idea in this cases when the first commit is not well formated.
-
Daniel-Constantin Mierla -
juha-h
-
Victor Seva