Hi all,
This has been in the back of my head from some time now. Libconfuse is a small project not distributed with major distros and unmaintained for 3.5 years now. As it is only used for reading of a simple cfg file, I want to write a simple parser that does the job(I do not want external deps ... see below why)
Benefits: we can now pack carrierroute with the common used modules (as it will not have any external dependencies) and also will remove a lot of problems seen on the list regarding linkage of libconfuse.
Any thoughts?
Marius
Sounds like a good idea to me. I don't build carrierroute in Enterprise Linux RPMs (and don't even consider it as an option on my deployments) for exactly this reason.
Regards,
Peter
On 20 October 2013 21:51, Marius Zbihlei mariuszbi@gmail.com wrote:
Hi all,
This has been in the back of my head from some time now. Libconfuse is a small project not distributed with major distros and unmaintained for 3.5 years now. As it is only used for reading of a simple cfg file, I want to write a simple parser that does the job(I do not want external deps ... see below why)
Benefits: we can now pack carrierroute with the common used modules (as it will not have any external dependencies) and also will remove a lot of problems seen on the list regarding linkage of libconfuse.
Any thoughts?
Marius
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Why bother writing a parser for the file when there is db_text? This will make the module simpler and easier to maintain.
Regards, Ovidiu Sas
On Sun, Oct 20, 2013 at 4:51 PM, Marius Zbihlei mariuszbi@gmail.com wrote:
Hi all,
This has been in the back of my head from some time now. Libconfuse is a small project not distributed with major distros and unmaintained for 3.5 years now. As it is only used for reading of a simple cfg file, I want to write a simple parser that does the job(I do not want external deps ... see below why)
Benefits: we can now pack carrierroute with the common used modules (as it will not have any external dependencies) and also will remove a lot of problems seen on the list regarding linkage of libconfuse.
Any thoughts?
Marius
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Is this something that could be done for 4.1.0? Would it count as a new feature, or simply a "fix" to make the module available on a wider range of platforms?
Regards,
Peter
On 20 October 2013 23:31, Ovidiu Sas osas@voipembedded.com wrote:
Why bother writing a parser for the file when there is db_text? This will make the module simpler and easier to maintain.
Regards, Ovidiu Sas
On Sun, Oct 20, 2013 at 4:51 PM, Marius Zbihlei mariuszbi@gmail.com wrote:
Hi all,
This has been in the back of my head from some time now. Libconfuse is a small project not distributed with major distros and unmaintained for 3.5 years now. As it is only used for reading of a simple cfg file, I want to write a simple parser that does the job(I do not want external deps ...
see
below why)
Benefits: we can now pack carrierroute with the common used modules (as
it
will not have any external dependencies) and also will remove a lot of problems seen on the list regarding linkage of libconfuse.
Any thoughts?
Marius
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
-- VoIP Embedded, Inc. http://www.voipembedded.com
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
I had a discussion with Henning about this a while ago and he insisted on keeping the libconfuse (more exactly the libconfuse style text config), don't remember exactly the details. I even raised this issue on the openser tracker: http://sourceforge.net/p/openser/feature-requests/145/
It would be nice to bring this module into the standard package.
Regards, Ovidiu Sas
On Sun, Oct 20, 2013 at 6:36 PM, Peter Dunkley peter.dunkley@crocodilertc.net wrote:
Is this something that could be done for 4.1.0? Would it count as a new feature, or simply a "fix" to make the module available on a wider range of platforms?
Regards,
Peter
On 20 October 2013 23:31, Ovidiu Sas osas@voipembedded.com wrote:
Why bother writing a parser for the file when there is db_text? This will make the module simpler and easier to maintain.
Regards, Ovidiu Sas
On Sun, Oct 20, 2013 at 4:51 PM, Marius Zbihlei mariuszbi@gmail.com wrote:
Hi all,
This has been in the back of my head from some time now. Libconfuse is a small project not distributed with major distros and unmaintained for 3.5 years now. As it is only used for reading of a simple cfg file, I want to write a simple parser that does the job(I do not want external deps ... see below why)
Benefits: we can now pack carrierroute with the common used modules (as it will not have any external dependencies) and also will remove a lot of problems seen on the list regarding linkage of libconfuse.
Any thoughts?
Marius
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
-- VoIP Embedded, Inc. http://www.voipembedded.com
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
-- Peter Dunkley Technical Director Crocodile RCS Ltd
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
For reference, there is an ini-like config parser in core, see cfg_parser.h -- it is used by tls module, afaik.
Cheers, Daniel
On 10/21/13 4:14 AM, Ovidiu Sas wrote:
I had a discussion with Henning about this a while ago and he insisted on keeping the libconfuse (more exactly the libconfuse style text config), don't remember exactly the details. I even raised this issue on the openser tracker: http://sourceforge.net/p/openser/feature-requests/145/
It would be nice to bring this module into the standard package.
Regards, Ovidiu Sas
On Sun, Oct 20, 2013 at 6:36 PM, Peter Dunkley peter.dunkley@crocodilertc.net wrote:
Is this something that could be done for 4.1.0? Would it count as a new feature, or simply a "fix" to make the module available on a wider range of platforms?
Regards,
Peter
On 20 October 2013 23:31, Ovidiu Sas osas@voipembedded.com wrote:
Why bother writing a parser for the file when there is db_text? This will make the module simpler and easier to maintain.
Regards, Ovidiu Sas
On Sun, Oct 20, 2013 at 4:51 PM, Marius Zbihlei mariuszbi@gmail.com wrote:
Hi all,
This has been in the back of my head from some time now. Libconfuse is a small project not distributed with major distros and unmaintained for 3.5 years now. As it is only used for reading of a simple cfg file, I want to write a simple parser that does the job(I do not want external deps ... see below why)
Benefits: we can now pack carrierroute with the common used modules (as it will not have any external dependencies) and also will remove a lot of problems seen on the list regarding linkage of libconfuse.
Any thoughts?
Marius
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
-- VoIP Embedded, Inc. http://www.voipembedded.com
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
-- Peter Dunkley Technical Director Crocodile RCS Ltd
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
So, i don't want to break the semantics of the cfg file, that's why i want a drop in replacement.
Also carrierroute is a peculiar beast, the cfg file and the db configuration (including db text) aren't equivalent feature wise and merging them will be quite difficult (mutually exclusive options).
I will have a look over the cfg_parser but again the grammar that we use is very simple and straightforward to use.
M. On Oct 21, 2013 6:27 AM, "Daniel-Constantin Mierla" miconda@gmail.com wrote:
For reference, there is an ini-like config parser in core, see cfg_parser.h -- it is used by tls module, afaik.
Cheers, Daniel
On 10/21/13 4:14 AM, Ovidiu Sas wrote:
I had a discussion with Henning about this a while ago and he insisted on keeping the libconfuse (more exactly the libconfuse style text config), don't remember exactly the details. I even raised this issue on the openser tracker: http://sourceforge.net/p/**openser/feature-requests/145/http://sourceforge.net/p/openser/feature-requests/145/
It would be nice to bring this module into the standard package.
Regards, Ovidiu Sas
On Sun, Oct 20, 2013 at 6:36 PM, Peter Dunkley <peter.dunkley@crocodilertc.**net peter.dunkley@crocodilertc.net> wrote:
Is this something that could be done for 4.1.0? Would it count as a new feature, or simply a "fix" to make the module available on a wider range of platforms?
Regards,
Peter
On 20 October 2013 23:31, Ovidiu Sas osas@voipembedded.com wrote:
Why bother writing a parser for the file when there is db_text? This will make the module simpler and easier to maintain.
Regards, Ovidiu Sas
On Sun, Oct 20, 2013 at 4:51 PM, Marius Zbihlei mariuszbi@gmail.com wrote:
Hi all,
This has been in the back of my head from some time now. Libconfuse is a small project not distributed with major distros and unmaintained for 3.5 years now. As it is only used for reading of a simple cfg file, I want to write a simple parser that does the job(I do not want external deps ... see below why)
Benefits: we can now pack carrierroute with the common used modules (as it will not have any external dependencies) and also will remove a lot of problems seen on the list regarding linkage of libconfuse.
Any thoughts?
Marius
______________________________**_________________ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/**cgi-bin/mailman/listinfo/sr-**devhttp://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
-- VoIP Embedded, Inc. http://www.voipembedded.com
______________________________**_________________ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/**cgi-bin/mailman/listinfo/sr-**devhttp://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
-- Peter Dunkley Technical Director Crocodile RCS Ltd
______________________________**_________________ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/**cgi-bin/mailman/listinfo/sr-**devhttp://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
-- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/**micondahttp://www.linkedin.com/in/miconda Kamailio Advanced Trainings - Berlin, Nov 25-28; Miami, Nov 18-20, 2013
- more details about Kamailio trainings at http://www.asipto.com -
______________________________**_________________ sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/**cgi-bin/mailman/listinfo/sr-**devhttp://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Hi Marius,
I will commit such a patch related to libconfuse. Maybe you want to have a look over it?
Thank you, Lucian Balaceanu
On 10/20/2013 11:51 PM, Marius Zbihlei wrote:
Hi all,
This has been in the back of my head from some time now. Libconfuse is a small project not distributed with major distros and unmaintained for 3.5 years now. As it is only used for reading of a simple cfg file, I want to write a simple parser that does the job(I do not want external deps ... see below why)
Benefits: we can now pack carrierroute with the common used modules (as it will not have any external dependencies) and also will remove a lot of problems seen on the list regarding linkage of libconfuse.
Any thoughts?
Marius
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
That would be great! Thanks!
Marius.
On Mon, Oct 21, 2013 at 8:04 AM, Lucian Balaceanu <lucian.balaceanu@1and1.ro
wrote:
** Hi Marius,
I will commit such a patch related to libconfuse. Maybe you want to have a look over it?
Thank you, Lucian Balaceanu
On 10/20/2013 11:51 PM, Marius Zbihlei wrote:
Hi all,
This has been in the back of my head from some time now. Libconfuse is a small project not distributed with major distros and unmaintained for 3.5 years now. As it is only used for reading of a simple cfg file, I want to write a simple parser that does the job(I do not want external deps ... see below why)
Benefits: we can now pack carrierroute with the common used modules (as it will not have any external dependencies) and also will remove a lot of problems seen on the list regarding linkage of libconfuse.
Any thoughts?
Marius
sr-dev mailing listsr-dev@lists.sip-router.orghttp://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Hello Marius,
I have attached a patched version of an internal parser for carrierroute. I would very much appreciate suggestions related to it. Some build dependencies would still have to be removed: fedora, openbsd and centos.
Thank you, Lucian Balaceanu
On 10/21/2013 11:04 AM, Marius Zbihlei wrote:
That would be great! Thanks! Marius.
On Mon, Oct 21, 2013 at 8:04 AM, Lucian Balaceanu <lucian.balaceanu@1and1.ro mailto:lucian.balaceanu@1and1.ro> wrote:
Hi Marius, I will commit such a patch related to libconfuse. Maybe you want to have a look over it? Thank you, Lucian Balaceanu On 10/20/2013 11:51 PM, Marius Zbihlei wrote:Hi all, This has been in the back of my head from some time now. Libconfuse is a small project not distributed with major distros and unmaintained for 3.5 years now. As it is only used for reading of a simple cfg file, I want to write a simple parser that does the job(I do not want external deps ... see below why) Benefits: we can now pack carrierroute with the common used modules (as it will not have any external dependencies) and also will remove a lot of problems seen on the list regarding linkage of libconfuse. Any thoughts? Marius _______________________________________________ sr-dev mailing list sr-dev@lists.sip-router.org <mailto:sr-dev@lists.sip-router.org> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev_______________________________________________ sr-dev mailing list sr-dev@lists.sip-router.org <mailto:sr-dev@lists.sip-router.org> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Hello Lucian,
Sorry for the delay I was fairly busy and also I wanted to try to use Rietveld(*) for doing the code review(@Daniel ever think about extending something like this to all commits or all patches coming from contributors?)
So, I will do my review here:
https://codereview.appspot.com/27270044/ (@Lucian see the comments section for needed improvement)
(*) developed by Guido Van Rossum when working at Google. FOSS, but requires AppEngine
On Fri, Nov 8, 2013 at 4:37 PM, Lucian Balaceanu lucian.balaceanu@1and1.rowrote:
Hello Marius,
I have attached a patched version of an internal parser for carrierroute. I would very much appreciate suggestions related to it. Some build dependencies would still have to be removed: fedora, openbsd and centos.
Thank you, Lucian Balaceanu
On 10/21/2013 11:04 AM, Marius Zbihlei wrote:
That would be great! Thanks!
Marius.
On Mon, Oct 21, 2013 at 8:04 AM, Lucian Balaceanu < lucian.balaceanu@1and1.ro> wrote:
Hi Marius,
I will commit such a patch related to libconfuse. Maybe you want to have a look over it?
Thank you, Lucian Balaceanu
On 10/20/2013 11:51 PM, Marius Zbihlei wrote:
Hi all,
This has been in the back of my head from some time now. Libconfuse is a small project not distributed with major distros and unmaintained for 3.5 years now. As it is only used for reading of a simple cfg file, I want to write a simple parser that does the job(I do not want external deps ... see below why)
Benefits: we can now pack carrierroute with the common used modules (as it will not have any external dependencies) and also will remove a lot of problems seen on the list regarding linkage of libconfuse.
Any thoughts?
Marius
sr-dev mailing listsr-dev@lists.sip-router.orghttp://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
sr-dev mailing listsr-dev@lists.sip-router.orghttp://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Hello,
what is the state with this patch?
This tracker item seems related:
- http://sip-router.org/tracker/index.php?do=details&task_id=353&proje...
Cheers, Daniel
On 16/11/13 20:36, Marius Zbihlei wrote:
Hello Lucian,
Sorry for the delay I was fairly busy and also I wanted to try to use Rietveld(*) for doing the code review(@Daniel ever think about extending something like this to all commits or all patches coming from contributors?)
So, I will do my review here:
https://codereview.appspot.com/27270044/ (@Lucian see the comments section for needed improvement)
(*) developed by Guido Van Rossum when working at Google. FOSS, but requires AppEngine
On Fri, Nov 8, 2013 at 4:37 PM, Lucian Balaceanu <lucian.balaceanu@1and1.ro mailto:lucian.balaceanu@1and1.ro> wrote:
Hello Marius, I have attached a patched version of an internal parser for carrierroute. I would very much appreciate suggestions related to it. Some build dependencies would still have to be removed: fedora, openbsd and centos. Thank you, Lucian Balaceanu On 10/21/2013 11:04 AM, Marius Zbihlei wrote:That would be great! Thanks! Marius. On Mon, Oct 21, 2013 at 8:04 AM, Lucian Balaceanu <lucian.balaceanu@1and1.ro <mailto:lucian.balaceanu@1and1.ro>> wrote: Hi Marius, I will commit such a patch related to libconfuse. Maybe you want to have a look over it? Thank you, Lucian Balaceanu On 10/20/2013 11:51 PM, Marius Zbihlei wrote:Hi all, This has been in the back of my head from some time now. Libconfuse is a small project not distributed with major distros and unmaintained for 3.5 years now. As it is only used for reading of a simple cfg file, I want to write a simple parser that does the job(I do not want external deps ... see below why) Benefits: we can now pack carrierroute with the common used modules (as it will not have any external dependencies) and also will remove a lot of problems seen on the list regarding linkage of libconfuse. Any thoughts? Marius _______________________________________________ sr-dev mailing list sr-dev@lists.sip-router.org <mailto:sr-dev@lists.sip-router.org> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev_______________________________________________ sr-dev mailing list sr-dev@lists.sip-router.org <mailto:sr-dev@lists.sip-router.org> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev _______________________________________________ sr-dev mailing list sr-dev@lists.sip-router.org <mailto:sr-dev@lists.sip-router.org> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
-
Daniel-Constantin Mierla -
Lucian Balaceanu -
Marius Zbihlei -
Ovidiu Sas -
Peter Dunkley