Add mqueue_name and mqueue_size to define queues. Updated doc.
<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
Add 2 new mqueue module parameters to simplify config queue definition. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2825
-- Commit Summary --
* mqueue: add two new module parameters
-- File Changes --
M src/modules/mqueue/doc/mqueue_admin.xml (58) M src/modules/mqueue/mqueue_mod.c (38)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2825.patch https://github.com/kamailio/kamailio/pull/2825.diff
@smititelu pushed 1 commit.
4a7eb271902476e701cbcf9af461b945efb40ec8 rtimer: add one new module parameter
Thanks, however I can't see a relevant simplification of the config, but could be a matter of taste, not being a real technical matter -- instead of one modparam line with both queue name and size, now can be two modparams, one with name and one with size.
I will wait a little bit more to see if any other comments, then I can merge it.
Hi Daniel,
Thanks for the input. Indeed not a real technical matter.
The actual usefulness of this is that after the commits one can set and use config #!defines for the new modparams (config "simplification" was not the right word; config "organization" is better).
Thank you, Stefan
Merged #2825 into master.
Hi Stefan,
I receive emails addressed to ***@***.******@***.***> (forwarded to me)
Dean is no longer with us and I cannot unsubscribe since I do not have his password. You can find Dean at ***@***.******@***.***>
Please unsubscribe ***@***.******@***.***> from the email list
Multzumesc
AT
From: Stefan Mititelu ***@***.***> Sent: Wednesday, August 18, 2021 3:35 AM To: kamailio/kamailio ***@***.***> Cc: Subscribed ***@***.***> Subject: Re: [kamailio/kamailio] mqueue: add two new module parameters (#2825)
Hi Daniel,
Thanks for the input. Indeed not a real technical matter.
The actual usefulness of this is that after the commits one can set and use config #!defines for the new modparams (config "simplification" was not the right word; config "organization" is better).
Thank you, Stefan
- You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkamailio%2Fkamailio%2Fpull%2F2825%23issuecomment-900889806&data=04%7C01%7Catopali%40unityconnected.com%7C488cc2c9c9ee48dc110308d9621abb05%7C8ddfdc7886484e968aceb311c211c8b2%7C0%7C0%7C637648689214609971%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=7GVlXvbgn8giX4k15o%2FTtVuoC0eogXXf%2BAZTw0zCKw0%3D&reserved=0, or unsubscribehttps://can01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAN5ZIBU2P3RHZHINNIDUDQDT5NPDNANCNFSM5CDMBB3A&data=04%7C01%7Catopali%40unityconnected.com%7C488cc2c9c9ee48dc110308d9621abb05%7C8ddfdc7886484e968aceb311c211c8b2%7C0%7C0%7C637648689214609971%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=H6Ih3zX%2FTwPn03B7wYGOEHamuA33euxX1oOtcBWE3Ew%3D&reserved=0.