### Description
I can see this error during db_mysql compilation on CentOS 7 ``` CC (gcc) [M db_mysql.so] km_dbase.o CC (gcc) [M db_mysql.so] km_val.o CC (gcc) [M db_mysql.so] km_row.o CC (gcc) [M db_mysql.so] km_my_con.o km_my_con.c: In function 'db_mysql_new_connection': km_my_con.c:183:15: error: 'MYSQL_OPT_SSL_CA' undeclared (first use in this function) ptr->con, MYSQL_OPT_SSL_CA, (const void *)db_mysql_opt_ssl_ca); ^ km_my_con.c:183:15: note: each undeclared identifier is reported only once for each function it appears in make[2]: *** [km_my_con.o] Error 1 make[1]: *** [modules] Error 1 make[1]: Leaving directory `/root/rpmbuild/BUILD/kamailio-5.8.1/src' make: *** [every-module] Error 2 ```
This for 5.8.1 release.
This is related to commit ea81e6cb8b2b2d896de7a07ce191876f9f182673 @space88man could you look.
For 5.8 and future is Kamailio still supporting CentOS 7 ?
CentOS 7 will be EoL, 30 June 2024 - not just EoL in terms of no more package updates, but it will be physically removed from all the CentOS mirrors.
https://blog.centos.org/2023/04/end-dates-are-coming-for-centos-stream-8-and...
I am fine with all of these cases: 1. add `#ifdef` for SSL support into db_mysql; 2. drop `CentOS 7` support; 3. build db_mysql module with MariaDB devel packages.
@miconda @linuxmaniac @henningw what is your opinion?
How about this change ```diff diff --git a/src/modules/db_mysql/km_my_con.c b/src/modules/db_mysql/km_my_con.c index 4c756db..bab3e44 100644 --- a/src/modules/db_mysql/km_my_con.c +++ b/src/modules/db_mysql/km_my_con.c @@ -178,9 +178,16 @@ struct my_con *db_mysql_new_connection(const struct db_id *id) } #endif /* MYSQL_VERSION_ID */ #endif /* MARIADB_BASE_VERSION */ + +#ifdef MYSQL_OPT_SSL_CA if(db_mysql_opt_ssl_ca) mysql_options( ptr->con, MYSQL_OPT_SSL_CA, (const void *)db_mysql_opt_ssl_ca); +#else + LM_WARN("opt_ssl_ca option not supported by mysql version (value %u) - " + "ignoring\n", + (unsigned int)db_mysql_opt_ssl_mode); +#endif /* MYSQL_OPT_SSL_CA */
#ifdef KSR_MYSQL_OPT_RECONNECT /* set reconnect flag if enabled */ ```
Closed #3809 as completed.
-
sergey-safarov -
space88man