[kamailio/kamailio] ims_registrar_scscf: changed str r_reginfo_s format: from 'version=%s… (#1961)
…' to 'version=%d'.
<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1961
-- Commit Summary --
* ims_registrar_scscf: changed str r_reginfo_s format: from 'version=%s' to 'version=%d'.
-- File Changes --
M src/modules/ims_registrar_scscf/registrar_notify.c (16) M src/modules/ims_registrar_scscf/registrar_notify.h (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1961.patch https://github.com/kamailio/kamailio/pull/1961.diff
Thank you for the pull-request. Can you explain a bit the motivation for the change, is it just a refactoring or does it fix a bug?
This is a bug fix. In NOTIFY message from S-CSCF to UE, Message Body contains different xml parameters and one of them can be a contact parameter with list of unknown-params. In some cases unknown-param has value with '%' inside. For instance: "urn%3Aurn-7%3A3gpp-service.ims.icsi.me". In this case, before the fix, adding of reginfo version breaks the string of unknown-param like this: "urn0X0P+0urn-70X0P+03gpp-service.ims.icsi.me". Adding reginfo version before contact parameters keeps unknown-param string unchanged.
On Mon, 20 May 2019 at 22:07, Henning Westerholt notifications@github.com wrote:
Thank you for the pull-request. Can you explain a bit the motivation for the change, is it just a refactoring or does it fix a bug?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kamailio/kamailio/pull/1961?email_source=notifications&email_token=ALKTZB6MUBLSU5AZ5LNVEJTPWLZFPA5CNFSM4HN72SCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVZZCJQ#issuecomment-494113062, or mute the thread https://github.com/notifications/unsubscribe-auth/ALKTZB72LCC24KBZUOSYWBTPWLZFPANCNFSM4HN72SCA .
Thank you, I merged it manually because of the not correct formatted commit log message.
Closed #1961.
-
alexyosifov -
Henning Westerholt