I am testing serial forking timers with the merged tm module and noticed that we have INV_FR_TIME_OUT_FIRST defined, in addition to IN_FR_TIME_OUT_NEXT.
INV_FR_TIME_OUT_FIRST does not seem to be used anywhere neither in sip-router nor in kamailio. Is this a relict and we can potentionally remove it and keep INV_FR_TIME_OUT_NEXT only, or do I miss something?
-- Jan
Jan Janak writes:
INV_FR_TIME_OUT_FIRST does not seem to be used anywhere neither in sip-router nor in kamailio. Is this a relict and we can potentionally remove it and keep INV_FR_TIME_OUT_NEXT only, or do I miss something?
jan,
i also did some checking and didn't find INV_FR_TIME_OUT_FIRST used. if i remember correctly, its idea was to allow longer wait for the first contacts to respond.
looks like it can be removed from the source.
-- juha
El Miércoles, 14 de Octubre de 2009, Juha Heinanen escribió:
Jan Janak writes:
INV_FR_TIME_OUT_FIRST does not seem to be used anywhere neither in sip-router nor in kamailio. Is this a relict and we can potentionally remove it and keep INV_FR_TIME_OUT_NEXT only, or do I miss something?
jan,
i also did some checking and didn't find INV_FR_TIME_OUT_FIRST used. if i remember correctly, its idea was to allow longer wait for the first contacts to respond.
Doesn't exist an AVP for that?
On Wed, Oct 14, 2009 at 9:26 PM, Iñaki Baz Castillo ibc@aliax.net wrote:
El Miércoles, 14 de Octubre de 2009, Juha Heinanen escribió:
Jan Janak writes: > INV_FR_TIME_OUT_FIRST does not seem to be used anywhere neither in > sip-router nor in kamailio. Is this a relict and we can potentionally > remove it and keep INV_FR_TIME_OUT_NEXT only, or do I miss something?
jan,
i also did some checking and didn't find INV_FR_TIME_OUT_FIRST used. if i remember correctly, its idea was to allow longer wait for the first contacts to respond.
Doesn't exist an AVP for that?
Yes, we are talking about a define in the source code.
-- Jan
PS: Didn't you promise me not to remove my e-mail address from the list of recipients? ;-)
Iñaki Baz Castillo writes:
i also did some checking and didn't find INV_FR_TIME_OUT_FIRST used. if i remember correctly, its idea was to allow longer wait for the first contacts to respond.
Doesn't exist an AVP for that?
no there does not exit an AVP for that and therefore also the constant can be removed.
-=- juha
On Wed, Oct 14, 2009 at 9:13 PM, Juha Heinanen jh@tutpro.com wrote:
Jan Janak writes:
> INV_FR_TIME_OUT_FIRST does not seem to be used anywhere neither in > sip-router nor in kamailio. Is this a relict and we can potentionally > remove it and keep INV_FR_TIME_OUT_NEXT only, or do I miss something?
jan,
i also did some checking and didn't find INV_FR_TIME_OUT_FIRST used. if i remember correctly, its idea was to allow longer wait for the first contacts to respond.
looks like it can be removed from the source.
OK, as far as I can tell it is exactly what INV_FR_TIME_OUT is for too, so I will remove the redundant define.
-- Jan