…e one parsed from the TCP connection
<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ V] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [V ] Tested changes locally - [ V] Related to issue #1353
#### Description <!-- Changed the rcv_info to hold the msg's receive info instead of the connection's -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1379
-- Commit Summary --
* This will update rcv_info to hold the correct receive info instead the one parsed from the TCP connection
-- File Changes --
M src/core/tcp_read.c (1)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1379.patch https://github.com/kamailio/kamailio/pull/1379.diff
Closed #1379.
Thanks! I pushed a slightly different patch to master and 5.1 branches, avoiding an assign, but main reason was to format properly the commit log message according to the contributing guidelines.
Thanks! I saw it Wanted to be official contributor =)
To merge a pull request directly, the commit log format must follow the guidelines from contributing guide:
- https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#com...
There is always space to improve documentation, cleanup code, etc ... no need to wait to hunt an issue, we welcome contributors in any place of the code and documentation!