[kamailio/kamailio] htable: Fix de-/increment w/ auto expire (PR #4079) - sr-dev

18 Dec 2024


      Update item expiration value during de-/incrementation for htables that are configured with autoexpire and updateexpire disabled. Otherwise an item cannot be used until timer cleaned it up.
&lt;!-- Kamailio Pull Request Template --&gt;
&lt;!--
IMPORTANT:
  - for detailed contributing guidelines, read:
    https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
  - pull requests must be done to master branch, unless they are backports
    of fixes from master branch to a stable branch
  - backports to stable branches must be done with &#39;git cherry-pick -x ...&#39;
  - code is contributed under BSD for core and main components (tm, sl, auth, tls)
  - code is contributed GPLv2 or a compatible license for the other components
  - GPL code is contributed with OpenSSL licensing exception
--&gt;
#### Pre-Submission Checklist
&lt;!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --&gt;
&lt;!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--&gt;
&lt;!-- If you&#39;re unsure about any of these, don&#39;t hesitate to ask on sr-dev mailing list --&gt;
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
&lt;!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --&gt;
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
Using following configuration
```
#!KAMAILIO
listen=udp:127.0.0.1:9999
log_stderror=yes
loadmodule &quot;xlog.so&quot;
loadmodule &quot;pv.so&quot;
loadmodule &quot;sl.so&quot;
loadmodule &quot;htable.so&quot;
modparam(&quot;htable&quot;, &quot;htable&quot;, &quot;foo=&gt;autoexpire=1;updateexpire=0&quot;)
request_route { if ($sht(foo=&gt;bar) == $null) { $sht(foo=&gt;bar) = 0; } $var(foo) = $shtdec(foo=&gt;bar); xlog(&quot;$Ts single value $sht(foo=&gt;bar)\texpire $shtex(foo=&g sl_send_reply(&quot;200&quot;, &quot;Hello&quot;); } ``` running ``` while true; do sleep 0.3; sipsak -vs sip:localhost:9999 ; done ``` produces following output ``` 0(1414153) ERROR: &lt;script&gt;: 1734539304 single value -1 expire 1 0(1414153) ERROR: &lt;script&gt;: 1734539305 single value -2 expire 0 0(1414153) ERROR: &lt;script&gt;: 1734539305 single value -3 expire 0 0(1414153) ERROR: &lt;script&gt;: 1734539305 single value -4 expire 0 0(1414153) ERROR: &lt;script&gt;: 1734539306 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539306 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539306 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539306 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539307 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539307 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539307 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539308 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539308 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539308 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539309 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539309 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539309 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539310 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539310 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539310 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539311 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539311 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539311 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539312 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539312 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539312 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539313 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539313 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539313 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539314 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539314 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539314 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539315 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539315 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539315 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539316 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539316 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539316 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539316 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539317 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539317 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539317 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539318 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539318 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539318 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539319 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539319 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539319 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539320 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539320 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539320 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539321 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539321 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539321 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539322 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539322 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539322 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539323 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539323 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539323 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539324 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539324 single value &lt;null&gt; 0(1414153) ERROR: &lt;script&gt;: 1734539324 single value -1 expire 1 0(1414153) ERROR: &lt;script&gt;: 1734539325 single value -2 expire 0 0(1414153) ERROR: &lt;script&gt;: 1734539325 single value -3 expire 0 0(1414153) ERROR: &lt;script&gt;: 1734539325 single value -4 expire 0 ``` When adding `initval=0` to `htable` configuration log output changes `&lt;null&gt;` You can view, comment on, or merge this pull request online at:

t;bar)\n&quot;); expire 4294967295 expire 4294967295 expire 4294967295 expire 4294967295 expire 4294967294 expire 4294967294 expire 4294967294 expire 4294967293 expire 4294967293 expire 4294967293 expire 4294967292 expire 4294967292 expire 4294967292 expire 4294967291 expire 4294967291 expire 4294967291 expire 4294967290 expire 4294967290 expire 4294967290 expire 4294967289 expire 4294967289 expire 4294967289 expire 4294967288 expire 4294967288 expire 4294967288 expire 4294967287 expire 4294967287 expire 4294967287 expire 4294967286 expire 4294967286 expire 4294967286 expire 4294967285 expire 4294967285 expire 4294967285 expire 4294967285 expire 4294967284 expire 4294967284 expire 4294967284 expire 4294967283 expire 4294967283 expire 4294967283 expire 4294967282 expire 4294967282 expire 4294967282 expire 4294967281 expire 4294967281 expire 4294967281 expire 4294967280 expire 4294967280 expire 4294967280 expire 4294967279 expire 4294967279 expire 4294967279 expire 4294967278 expire 4294967278 expire 4294967278 expire 4294967277 expire 4294967277 to `0`
https://github.com/kamailio/kamailio/pull/4079
-- Commit Summary --
* htable: Fix de-/increment w/ auto expire
-- File Changes --
M src/modules/htable/ht_api.c (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/4079.patch
https://github.com/kamailio/kamailio/pull/4079.diff
-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4079
You are receiving this because you are subscribed to this thread.

Message ID: &lt;kamailio/kamailio/pull/4079@github.com&gt;