<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description in high volume systems with ephemeral user location data (e.g. very low expiration times on user location records), the user location delete action can cause a high amount of DMQ traffic when UAs unregister. This new parameter allows the user location `delete` action to be disabled from being shared across DMQ nodes which helps reduce DMQ traffic on systems with high register/unregister rates and low expiration times. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2358
-- Commit Summary --
* dmq_usrloc: add new parameter `usrloc_delete` to disable synchronizing delete actions
-- File Changes --
M src/modules/dmq_usrloc/dmq_usrloc.c (2) M src/modules/dmq_usrloc/doc/dmq_usrloc.xml (16) M src/modules/dmq_usrloc/doc/dmq_usrloc_admin.xml (20) M src/modules/dmq_usrloc/usrloc_sync.c (5)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2358.patch https://github.com/kamailio/kamailio/pull/2358.diff
Very nice feature, cheers for that!
But just to be clear, how do the contact bindings get aged out, in the absence of delete operations pushed across DMQ? Are they subject to the same local `usrloc` expiration logic in that case?
Yes, each kamailio server will remove contact records as they expire. In our use case, they expire within 60s on each kamailio server.
And this happens via the normal usrloc timer processes, right?
Yes, exactly.
That really is an excellent feature, thank you for putting it together!
Thanks!
Merged #2358 into master.