<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail --> Adding add_uri_param method to kemi
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3268
-- Commit Summary --
* siputils: adding add_uri_param to kemi
-- File Changes --
M src/modules/siputils/siputils.c (5)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3268.patch https://github.com/kamailio/kamailio/pull/3268.diff
Thanks for proposing the PR!
I pushed an alternative implementation (commit ad4faf03628db45d30f27358b81afd8e0bee03c0) with explicit definition of the kemi function, the one for cfg-export can change and be untraceable. Also very important, it fails to be detected by the python script that extracts the kemi exports for documentation index.
Furthermore, the git commit message was the PR template text. It has to only describe what changes are done, not what is required to fill in the PR template.
Closed #3268.