[kamailio/kamailio] Potential resource leaks (Issue #2983) - sr-dev

ryancaicse

21 Dec 2021 21 Dec '21

2:42 p.m.

`fclose(pf);` should be put before `Line 295`? https://github.com/kamailio/kamailio/blob/1ddc27f199061025a6a43da3e8a1388fca...

-- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2983 You are receiving this because you are subscribed to this thread. Message ID: kamailio/kamailio/issues/2983@github.com

Attachments:

attachment.html (text/html — 2.0 KB)

Show replies by date

ryancaicse

21 Dec 21 Dec

2:43 p.m.

-- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2983#issuecomment-998834907 You are receiving this because you are subscribed to this thread. Message ID: kamailio/kamailio/issues/2983/998834907@github.com

ryancaicse

2:43 p.m.

https://github.com/kamailio/kamailio/blob/1ddc27f199061025a6a43da3e8a1388fca...

-- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2983#issuecomment-998835252 You are receiving this because you are subscribed to this thread. Message ID: kamailio/kamailio/issues/2983/998835252@github.com

Henning Westerholt

3:20 p.m.

New subject: [kamailio/kamailio] Potential resource leaks (auth_identity, test code) (Issue #2983)

Thanks for the report. The two test files are probably no big issue, but the module is surely more important.

-- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2983#issuecomment-998864627 You are receiving this because you are subscribed to this thread. Message ID: kamailio/kamailio/issues/2983/998864627@github.com

Daniel-Constantin Mierla

22 Dec 22 Dec

7:20 a.m.

New subject: [kamailio/kamailio] Potential resource leaks (auth_identity, test code) (Issue #2983)

I pushed a commit for auth_identity for making it clean, because the code in is mod_inti and in case of errors, kamailio does not start, it shuts down and OS cleans up all resources. Moreover, I am not sure anyone uses it, the module is the implementation of the previous specs for caller identity, superseded by STIR/SHAKEN.

The test code is not used by kamailio app, it's just some testing case added by developers in early days of development for side testing. Upon review, probably most of them can be removed.

-- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2983#issuecomment-999342959 You are receiving this because you are subscribed to this thread. Message ID: kamailio/kamailio/issues/2983/999342959@github.com

Daniel-Constantin Mierla

7:20 a.m.

New subject: [kamailio/kamailio] Potential resource leaks (auth_identity, test code) (Issue #2983)

Closed #2983.

-- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2983#event-5803035902 You are receiving this because you are subscribed to this thread. Message ID: kamailio/kamailio/issue/2983/issue_event/5803035902@github.com

ryancaicse

7:26 a.m.

New subject: [kamailio/kamailio] Potential resource leaks (auth_identity, test code) (Issue #2983)

@miconda Thank you for your efforts!!

-- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2983#issuecomment-999345857 You are receiving this because you are subscribed to this thread. Message ID: kamailio/kamailio/issues/2983/999345857@github.com

1210

Age (days ago)

1211

Last active (days ago)

sr-dev@lists.kamailio.org

6 comments

3 participants

tags (0)

participants (3)

Daniel-Constantin Mierla
Henning Westerholt
ryancaicse