Hi Daniel,

i am really, really sorry. The later the day, the easier i forget how the commit message for Kamailio should look like... In the other repositories, where i commit, we do not care that much about the commit messages. This time i made a post-it on my monitor; in order to get it right next time. I've changed the commit messages accordingly.

Thanks again, Carsten

2013/9/30 Daniel-Constantin Mierla miconda@gmail.com:

Hello,

you made a lot of commits without proper formatting of the first line in the commit message.

I wrote you several times to use the format that makes the change log coherent, the format used by all other developers.

Is it a problem with that format?

Thanks, Daniel

On 9/30/13 8:46 PM, Carsten Bock wrote:

...

Module: sip-router Branch: tmp/ims_charging Commit: 6fdc83ecd7fa5313635a0041e76498704b0c8225 URL: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=6fdc83ec...

Author: Carsten Bock carsten@ng-voice.com Committer: Carsten Bock carsten@ng-voice.com Date: Mon Sep 30 20:46:30 2013 +0200

Beautified XML-Doc for IMS-Charging

---

modules/ims_charging/doc/ims_charging_admin.xml | 1111 +++++++++++------------ 1 files changed, 514 insertions(+), 597 deletions(-)

Diff: http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commitdiff;h=6fdc...

---

sr-dev mailing list sr-dev@lists.sip-router.org http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

-- Daniel-Constantin Mierla - http://www.asipto.com http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda Kamailio Advanced Trainings - Berlin, Nov 25-28; Miami, Nov 18-20, 2013

• more details about Kamailio trainings at http://www.asipto.com -

2013/10/1 Olle E. Johansson oej@edvina.net:

A git question that's related:

Can I change a commit message?

git commit --amend

But only if you have not pushed the commit yet. You should never rewrite the git history on a public repository.

Cheers, Victor

2013/10/1 Carsten Bock carsten@ng-voice.com:

before merging into master.

That was my point. You are right about rebase with unpushed commits.