[kamailio/kamailio] core: Zero terminate str copies made with (pkg|shm)_str_dup() (#2519)
<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [x] Related to PR #2512
#### Description <!-- Describe your changes in detail --> As discussed in #2512, zero-terminating all copies is preferred as most str usage is already with zero-terminated str.s.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2519
-- Commit Summary --
* core: Zero terminate str copies made with (pkg|shm)_str_dup()
-- File Changes --
M src/core/ut.h (8)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2519.patch https://github.com/kamailio/kamailio/pull/2519.diff
Thanks, it can be merged!
Merged #2519 into master.
Merged myself. Somehow I thought @gaaf has commit access already, but I was mistaken.
Somehow I thought @gaaf has commit access already, but I was mistaken.
That was before the migration to github.
The docs in str.h should be probably changed as well (here is documented that str is not null-terminated). Also probably a good idea to review other invocation of this utilty functions in the modules, now there might be double null-termination done somewhere (might be harmless in most cases, though).
Something like this: #2520 ?
I think that chances of double zero-termination are low when using these functions as it required 2 allocations in succession. Most uses of zero-terminated str will be open-coded to prevent that.
-
Alex Hermann -
Daniel-Constantin Mierla
-
Henning Westerholt