<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [x] PR should be backported to stable branches - [ ] Tested changes locally
#### Description
If kamailio is in the shutdown phase proc timers should not be executed since memory objects are getting destroyed and cores could happen
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3649
-- Commit Summary --
* core: timer_proc don't execute timers on destroy_modules_phase
-- File Changes --
M src/core/timer_proc.c (19)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3649.patch https://github.com/kamailio/kamailio/pull/3649.diff
I think `ksr_shutdown_phase()` has to be used in this case, because the timers are different processes, `destroy_modules_phase()` is for main/parent process only.
@linuxmaniac pushed 1 commit.
5b9b8de9dd5d565e8d50cce3dcaaaa1271b2e84e core: timer_proc don't execute timers on shutdown phase
Nothing explodes in my tests
@miconda do you think this can be merged?
Yes, thanks!
Merged #3649 into master.