Record-Routing in in-dialog request are not needed by RFC 3261. But there are many clients out there not sending initial route-set in in-dialog requests. To provided them with the initial route-set together with UAC modified requests the ;ftag parameter must be the to-tag on upstream requests. append_fromtag parameter added the tag value from "from" header always, even on upstream. This is fixed here.
It is not done on record_route_preset().
Handles issue #536 You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/537
-- Commit Summary --
* append_fromtag on upstream in-dialog requests * Merge pull request #1 from schoberw/append_fromtag_upstream
-- File Changes --
M modules/rr/record.c (43)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/537.patch https://github.com/kamailio/kamailio/pull/537.diff
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/537
Thanks! I pushed the commit manually with you as author to get rid of extra merge pull request notification, but also follow the commit message guidelines for formatting (which I forgot to point to previously):
* http://www.kamailio.org/wiki/devel/github-contributions#commit_message_forma...
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/537#issuecomment-194221695
Closed #537.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/537#event-583047245
-
Daniel-Constantin Mierla -
schoberw