[kamailio/kamailio] Add mandatory Max-Forwards header to local ACK (PR #3856)

List overview All Threads
Download

newer

older

Re: [kamailio/kamailio] tm: add...

git:5.8:3a34b468: tm: add...

juha-h

20 May 2024 20 May '24

4:45 a.m.

#### Type Of Change - [ x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x ] PR should be backported to stable branches - [ x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Add mandatory Max-Forwards header to local ACK You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3856 -- Commit Summary -- * Add mandatory Max-Forwards header to local AC -- File Changes -- M src/modules/tm/t_msgbuilder.c (5) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3856.patch https://github.com/kamailio/kamailio/pull/3856.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856 You are receiving this because you are subscribed to this thread. Message ID: &lt;kamailio/kamailio/pull/3856(a)github.com&gt;

Attachments:

attachment.html (text/html — 3.4 KB)

Show replies by date

juha-h

20 May 20 May

4:52 a.m.

@juha-h pushed 1 commit. 91747524b2e4b34fa1b68c8d5b0e0473cf2f2ff8 Run clang-format on the file -- View it on GitHub: https://github.com/kamailio/kamailio/pull/3856/files/b9b90eb6ea5cb20466a74a… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3856/push/18498353577(a)github.com>

Daniel-Constantin Mierla

5:04 a.m.

Remember that the git commit message first line has to be formatted as per contributing guidelines, it has to be prefixed with the component name: - https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#co… The commit messages are used for generating the changelog for releases as well as making easier to figure out what was impacted by a commit. Having the commit message in the proper format makes it easier to merge as well directly from the git PR portal. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120007340 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3856/c2120007340(a)github.com>

juha-h

5:07 a.m.

Same checks bug as earlier: according to Details, check-format PASSED, but there still claim that `Some checks were not successful`. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120012806 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3856/c2120012806(a)github.com>

Victor Seva

5:41 a.m.

New subject: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)

@juha-h is not a bug. The format checks each commit. I already told you how to properly do it. Just create one commit with the proper commit message prefix squashing both previous commits in the branch. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120073595 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3856/c2120073595(a)github.com>

juha-h

5:53 a.m.

New subject: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)

Victor Seva writes:

...

Just create one commit with the proper commit message prefix squashing both previous commits in the branch.

Goes beyond me. In baresip project, nothing like that needs to be done. If there is new commit to PR, all checks are automatically re-run. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120096511 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3856/c2120096511(a)github.com>

juha-h

5:59 a.m.

New subject: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)

juha-h writes:

...

Goes beyond me. In baresip project, nothing like that needs to be done. If there is new commit to PR, all checks are automatically re-run.

... and red marks turn green without any extra action. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120106704 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3856/c2120106704(a)github.com>

Victor Seva

6:03 a.m.

New subject: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)

since it's a branch in kamailio repo I did it myself. ``` git rebase -i origin/master ``` squashed both commits and added the tm prefix -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120114049 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3856/c2120114049(a)github.com>

Victor Seva

6:05 a.m.

New subject: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)

The idea behind it's that all commits are properly formatted. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120117882 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3856/c2120117882(a)github.com>

Victor Seva

6:19 a.m.

New subject: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)

Merged #3856 into master. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#event-12864279478 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3856/issue_event/12864279478(a)github.com>

juha-h

7:27 a.m.

New subject: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)

Is it OK to cherry-pick this to 5.8 branch? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120256287 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3856/c2120256287(a)github.com>

Daniel-Constantin Mierla

12:48 p.m.

New subject: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)

Yes, it can be cherry-picked, it is about a mandatory header. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120822692 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3856/c2120822692(a)github.com>

juha-h

12:56 p.m.

New subject: [kamailio/kamailio] tm: add mandatory Max-Forwards header to local ACK (PR #3856)

Daniel-Constantin Mierla writes:

...

Yes, it can be cherry-picked, it is about a mandatory header.

Done. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3856#issuecomment-2120834113 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3856/c2120834113(a)github.com>

days inactive

days old

sr-dev@lists.kamailio.org

Manage subscription

12 comments

3 participants

tags (0)

participants (3)

Daniel-Constantin Mierla
juha-h
Victor Seva