#### Type Of Change - [ x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: - [x ] PR should be backported to stable branches - [ x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description Add mandatory Max-Forwards header to local ACK
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3856
-- Commit Summary --
* Add mandatory Max-Forwards header to local AC
-- File Changes --
M src/modules/tm/t_msgbuilder.c (5)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3856.patch https://github.com/kamailio/kamailio/pull/3856.diff
@juha-h pushed 1 commit.
91747524b2e4b34fa1b68c8d5b0e0473cf2f2ff8 Run clang-format on the file
Remember that the git commit message first line has to be formatted as per contributing guidelines, it has to be prefixed with the component name:
- https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#com...
The commit messages are used for generating the changelog for releases as well as making easier to figure out what was impacted by a commit. Having the commit message in the proper format makes it easier to merge as well directly from the git PR portal.
Same checks bug as earlier: according to Details, check-format PASSED, but there still claim that `Some checks were not successful`.
@juha-h is not a bug. The format checks each commit. I already told you how to properly do it.
Just create one commit with the proper commit message prefix squashing both previous commits in the branch.
Victor Seva writes:
Just create one commit with the proper commit message prefix squashing both previous commits in the branch.
Goes beyond me. In baresip project, nothing like that needs to be done. If there is new commit to PR, all checks are automatically re-run.
juha-h writes:
Goes beyond me. In baresip project, nothing like that needs to be done. If there is new commit to PR, all checks are automatically re-run.
... and red marks turn green without any extra action.
since it's a branch in kamailio repo I did it myself.
``` git rebase -i origin/master ```
squashed both commits and added the tm prefix
The idea behind it's that all commits are properly formatted.
Merged #3856 into master.
Is it OK to cherry-pick this to 5.8 branch?
Yes, it can be cherry-picked, it is about a mandatory header.
Daniel-Constantin Mierla writes:
Yes, it can be cherry-picked, it is about a mandatory header.
Done.
-
Daniel-Constantin Mierla -
juha-h
-
Victor Seva