<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3602
#### Description Added missing code for database backend to work. Tested basic scenarios locally for all db modes. DB schema could be tweaked according to my thoughts in issue #3602, but that also applies to several other modules which are done in the same matter. Because of that, I didn't consider such a change now.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3603
-- Commit Summary --
* ims_dialog: Add support for database backend
-- File Changes --
M src/modules/ims_dialog/dlg_db_handler.c (9) M src/modules/ims_dialog/dlg_handlers.c (52) M src/modules/ims_dialog/dlg_hash.c (5) M src/modules/ims_dialog/doc/ims_dialog_admin.xml (93)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3603.patch https://github.com/kamailio/kamailio/pull/3603.diff
Seems like there's some issue with the CodeQL Analyzer (runner image out of disk space)?
Thanks! CodeQL can indeed fail from other reasons than the code, can be ignored if that happens.
Regarding the patch of the PR, I could spot only a database delete operation being added. The commit message says `Add support for database backend`. Was there code for database support but not activated? If yes, only the db delete operation was missing?
Like I wrote in the ticket related to this task, most of the stuff was there already - but it both caused a crash and was not fully functional. Entries were being written to the database, but was not restored correctly on startup.
I assume the old dialog module was used as a basis and that the code for db operations was not finalized with the new structure.
The missing delete was probably a result of that, since this new module got two tables ("in" and "out") compared to only one in the old module.
My plan is to have this merged and then continue working on db operations for the ims_charging module. I just wanted to have this completed first, since the other part will not work without it.
Thanks for the details, I am not using the module, I wanted to be sure nothing was omitted -- I am going to merge it.
Merged #3603 into master.
-
Daniel-Constantin Mierla -
mtryfoss