Hi, guys!
Pua module provides a callback "send_publish". One of the parameters is "outbound_proxy", but pua_reginfo does not use it, even if the parameter is specified.
Documentation says: "The outbound_proxy uri to be used when sending Subscribe requests." Any reason to use it only for SUBSCRIBE, and not for PUBLISH?
If PR is acceptable, do I need to correct documentation for pua_reginfo module?
I have studied the contributing gide, but if something is not OK - please point out,. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1176
-- Commit Summary --
* Update usrloc_cb.c
-- File Changes --
M src/modules/pua_reginfo/usrloc_cb.c (3)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1176.patch https://github.com/kamailio/kamailio/pull/1176.diff
The commit message is not good, it is `Update usrloc_cb.c`, whichd doesn't describe what the patch does, not it follows the guidelines for contributions. Actually, the title of this pull request is suitable for commit message -- see:
* https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#com...
Can you rework the patch so it has proper commit message as well as amend the documentation to reflect the use of outbound proxy for publish as well?
Closed #1176.
-
Daniel-Constantin Mierla -
Vasiliy Ganchev