[kamailio/kamailio] pua_json: new module to update presence using JSON data objects (#1424)
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/1424
-- Commit Summary --
* presence: print message at INFO loglevel in check_if_dialog() since not all presentity updates will be dialog events * pua_json: new module to update presence using json objects
-- File Changes --
M src/modules/presence/presentity.c (2) A src/modules/pua_json/Makefile (17) A src/modules/pua_json/README (0) A src/modules/pua_json/defs.h (133) A src/modules/pua_json/doc/Makefile (4) A src/modules/pua_json/doc/pua_json.xml (37) A src/modules/pua_json/doc/pua_json_admin.xml (105) A src/modules/pua_json/pua_json_mod.c (70) A src/modules/pua_json/pua_json_mod.h (39) A src/modules/pua_json/pua_json_publish.c (405) A src/modules/pua_json/pua_json_publish.h (32)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/1424.patch https://github.com/kamailio/kamailio/pull/1424.diff
lazedo commented on this pull request.
- Kamailio is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version + * + * Kamailio is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * + * Contributor(s): + * Emmanuel Schmidbauer eschmidbauer@gmail.com
@eschmidbauer sorry for this.. but, what % of this code is actually `only` yours ? same thing in other files on this `new` module. don't get me wrong, i approve this move from a `kazoo` centric solution to a generic one and i'm glad you found the time to make this happen.
eschmidbauer commented on this pull request.
- Kamailio is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version + * + * Kamailio is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * + * Contributor(s): + * Emmanuel Schmidbauer eschmidbauer@gmail.com
If you look at line 4 of the files that were mostly borrowed from kazoo, i included: ``` * Copyright (C) 2010-2014 2600Hz ```
This can be merged, but then remove the Contributors from C code files (can be a follow up commit) -- we removed history/contributors in most of the code files, with the goal to do it everywhere, so make no sense to add new ones. The git commit can be used to see the contributions over the time and explicit listing of names/companies can be done in the README file. Having in C code file can end up with a large listing over many years.
Merged #1424.
-
Daniel-Constantin Mierla -
Emmanuel Schmidbauer
-
lazedo