#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [X] Tested changes locally
#### Description Add path value to xavp_rcd. This is needed when checking if a subscriber is still registered with a certain parameter in the path.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2162
-- Commit Summary --
* registrar: add path value to xavp_rcd
-- File Changes --
M src/modules/registrar/doc/registrar_admin.xml (8) M src/modules/registrar/lookup.c (8)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2162.patch https://github.com/kamailio/kamailio/pull/2162.diff
This is a small change and a good extension, I think it is fine to merge it.
I am fine to merge, but probably we should add in short term a new parameter to control what attributes are cloned in xavp, some of them can be large in size like, path with couple of hops, and maybe not needed in specific cases.
@miconda something like `modparam("registrar", "xavp_rcd_mask", 0)` so we can define what to load?
@linuxmaniac - yes, but can be also the opposite condition: what to skip. What people find better.
I like "what to skip" more, in the end most people would probably use it on smaller installations.
Ok, I'm going to merge and I will work on the module parameter to define what values to skip
Merged #2162 into master.