* default behavior of rtpengine is trust-address * use SIP-source-address for nat_uac_test("8")
<!-- Kamailio Pull Request Template -->
<!-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable branch - backports to stable branches must be done with 'git cherry-pick -x ...' - code is contributed under BSD for core and main components (tm, sl, auth, tls) - code is contributed GPLv2 or a compatible license for the other components - GPL code is contributed with OpenSSL licensing exception -->
#### Pre-Submission Checklist <!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply --> <!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above--> <!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list --> - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist: <!-- Go over all points below, and after creating the PR, tick the checkboxes that apply --> - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description <!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2656
-- Commit Summary --
* kamailio.cfg: use SIP-source-address
-- File Changes --
M etc/kamailio.cfg (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2656.patch https://github.com/kamailio/kamailio/pull/2656.diff
Maybe is just better to skip the `nat_uac_test("8")` condition and have simply one time just:
``` rtpengine_manage("replace-origin replace-session-connection"); ```
The `trust-address` was mainly to avoid deadlocks in RTP relay chains, when one app waits for the other to send first RTP packet, but it is fine to remove it being the default for quite long time.
Not sure if `SIP-source-address` is much useful, I would rather leave it with default behaviour for natted SDP. Also, in case of a chain of RTP relays in the cloud, the RTP relay app may run on a different system than the SIP server.
Not sure if `SIP-source-address` is much useful, I would rather leave it with default behaviour for natted SDP. Also, in case of a chain of RTP relays in the cloud, the RTP relay app may run on a different system than the SIP server.
Valid points and I guess it goes to the old question of "what is the default kamailio used for?" I don't have an answer. I think if we do have the check, it would be best to switch to the behavior for rtpengine, but don't have a strong opinion either way.
In essence, wouldn't the daisy chain scenario be the same for rtpproxy as well?
Let's merge this one for now to have backward compatibility with expected behaviour and we can review again the entire config file before releasing next major version, as we use to do it at that time. Thanks!
Merged #2656 into master.
-
Daniel-Constantin Mierla -
Fred Posner