Tested with FreeBSD 10 and Linux 3.2 (Debian Wheezy 7.6). List of other platforms gathered with [FreeBSD and Linux Kernel Cross-Reference](http://fxr.watson.org/fxr/trackident?i=TCP_KEEPIDLE) You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/491
-- Commit Summary --
* tcp: use macros from netinet/tcp.h to detect TCP feature * modules/tcpops: fix documentation typo * modules/tcpops: update list of platforms
-- File Changes --
M modules/tcpops/doc/functions.xml (10) M modules/tcpops/doc/tcpops.xml (2) M tcp_options.h (14)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/491.patch https://github.com/kamailio/kamailio/pull/491.diff
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/491
Thanks for the patch. I'm not sure where `tcp_options.h` gets the `TCP_KEEP*` macros defined from, do I miss something?
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/491#issuecomment-175786450
I have those in netinet/tcp.h. It is included by tcp_main.c and modules/tcpops/tcpops.c Can this still work?
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/491#issuecomment-175790500
then it would make sense to also include `netinet/tcp.h` in `tcp_options.h`, to avoid any issue in the future if `tcp_options.h` is re-used elsewhere
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/491#issuecomment-176066008
Merged #491.
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/491#event-531446010
Merged, thanks for enabling the functionality on BSD
--- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/491#issuecomment-176809248
-
Camille Oudot -
Mikko Lehto