This allows building with Solaris Studio, tested with 12.4. You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/689
-- Commit Summary --
* core: fix Sun Studio build * counters: fix return statement in void function * dialog: remove return statement from void functions * ctl: remove return statement from void function * pdb: set packed attribute on enum conditionally * uid_avp_db: remove GCC specific -Wall
-- File Changes --
M Makefile.defs (27) M action.c (13) M atomic/atomic_sparc64.h (3) M io_wait.h (4) M ip_addr.h (1) M mem/memdbg.h (13) M modules/counters/counters.c (5) M modules/ctl/binrpc_run.c (2) M modules/dialog/dlg_handlers.c (4) M modules/pdb/common.h (12) M modules/tls/tls_bio.c (18) M modules/tls/tls_server.c (18) M modules/uid_avp_db/Makefile (1) M sr_module.h (8) M tls_hooks.h (21) M utils/kamcmd/parse_listen_id.c (10)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/689.patch https://github.com/kamailio/kamailio/pull/689.diff
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/689
Analyzing the first patch (3678a66) -- it is adding a restriction on using only C99 compilers, right? Meaning that old compilers that support only c90 are no longer going to work ...
I think I am fine over all, but we should check if someone has something against as some people used to build on some old embedded systems.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/689#issuecomment-229886257
Hi Daniel, I have update the PR to maintain the GCC CPP compatibility. That was an oversight, I didn't consider embedded systems that might not support C99.
Thanks, Spencer
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/689#issuecomment-229965214
Thanks! At some point we'll ave to review and see how much of the legacy stuff we should to keep ...
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/689#issuecomment-230226208
Merged #689.
--- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/689#event-711712991
-
Daniel-Constantin Mierla -
sjthomason