29 Jan
2017
29 Jan
'17
1:45 p.m.
Related to http://lists.sip-router.org/pipermail/sr-users/2017-January/095772.html
Resetting the flag in t_suspend allows adding new branches in a failure route while
suspending the transaction.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/955
-- Commit Summary --
* tm: reset T_ASYNC_CONTINUE flag in t_suspend
-- File Changes --
M src/modules/tm/t_suspend.c (3)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/955.patch
https://github.com/kamailio/kamailio/pull/955.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/955
30 Jan
30 Jan
5:31 p.m.
Probably it's ok -- couldn't see a side effect right now. Is it tested/used
anywhere else than src/modules/tm/t_reply.c:1123?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/955#issuecomment-276045925
5:33 p.m.
Currently it's only used in that t_reply check.
On Mon, Jan 30, 2017 at 1:01 PM, Daniel-Constantin Mierla <
notifications(a)github.com> wrote:
Probably it's ok -- couldn't see a side effect
right now. Is it
tested/used anywhere else than src/modules/tm/t_reply.c:1123?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/kamailio/kamailio/pull/955#issuecomment-276045925>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADip4w48vD_4NkGmo1-ISG2b8JWDK1Uzks5rXdEJgaJpZM4LwvBV>
.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/955#issuecomment-276046403
5:49 p.m.
Unless you think it should be better to be reset when t_continue() is finished instead of
inside t_suspend(), you can merge it.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/955#issuecomment-276049199
5:51 p.m.
You're right, I'll try this 2nd approach.
On Mon, Jan 30, 2017 at 1:19 PM, Daniel-Constantin Mierla <
notifications(a)github.com> wrote:
Unless you think it should be better to be reset when
t_continue() is
finished instead of inside t_suspend(), you can merge it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/kamailio/kamailio/pull/955#issuecomment-276049199>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADip4-uUCfyyOtIztbsfOXue3BnqzQh_ks5rXdVHgaJpZM4LwvBV>
.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/955#issuecomment-276049555
7:21 p.m.
Thinking it better, wouldn't moving the flag reset at the end of t_continue
make the check in t_reply useless?
I have to admit that I don't fully understand that check anyway :)
On Mon, Jan 30, 2017 at 1:21 PM, Federico Cabiddu <notifications(a)github.com>
wrote:
You're right, I'll try this 2nd approach.
On Mon, Jan 30, 2017 at 1:19 PM, Daniel-Constantin Mierla <
notifications(a)github.com> wrote:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<https://github.com/kamailio/kamailio/pull/955#issuecomment-276049555>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF36ZYAsvBRJ6KyaWuVm-Jg6pmA9CZoIks5rXdXKgaJpZM4LwvBV>
.
_______________________________________________
sr-dev mailing list
sr-dev(a)lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
Unless you think it should be better to be reset
when t_continue() is
finished instead of inside t_suspend(), you can merge it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/kamailio/kamailio/pull/955#issuecomment-276049199>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADip4-
uUCfyyOtIztbsfOXue3BnqzQh_ks5rXdVHgaJpZM4LwvBV>
.
8:36 p.m.
It's a bit foggy the purpose right now, or better said the duration when that flag is
needed. I didn't have the time to dig into it too much and don't remember the full
purpose for it right now. I expected to be related to the fact of choosing the final
response while a suspended branch is still processed.
But I think your patch is better in this regard, because it preserves the old behaviour
(which didn't have a complaint on this flag) longer, until a new suspend is done. So
can be merged as it is.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/955#issuecomment-276086137
8:42 p.m.
Thanks, should I backport it too?
On Mon, Jan 30, 2017 at 4:06 PM, Daniel-Constantin Mierla <
notifications(a)github.com> wrote:
It's a bit foggy the purpose right now, or better
said the duration when
that flag is needed. I didn't have the time to dig into it too much and
don't remember the full purpose for it right now. I expected to be related
to the fact of choosing the final response while a suspended branch is
still processed.
But I think your patch is better in this regard, because it preserves the
old behaviour (which didn't have a complaint on this flag) longer, until a
new suspend is done. So can be merged as it is.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/kamailio/kamailio/pull/955#issuecomment-276086137>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADip44rHstoc23NanawiPEhAdBUkWDJwks5rXfx4gaJpZM4LwvBV>
.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/955#issuecomment-276087863
8:43 p.m.
Merged #955.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/955#event-941479429
2915
days inactive
2916
days old
8 comments
3 participants
participants (3)
-
Daniel-Constantin Mierla -
Federico Cabiddu
-
Federico Cabiddu